Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDN: Design routes and policies on L2's GR correctly. #4694

Merged
merged 12 commits into from
Sep 18, 2024
Merged

UDN: Design routes and policies on L2's GR correctly. #4694

merged 12 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Layer2 UDN: Rename gateway switch ports 

    In Layer2 networks there is no join switch, only the cluster switch.
Ensure that the ports are named appropriately, this is important for
the logical router policies created for local node access.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 967923e)
    @kyrtapz @tssurya
    kyrtapz authored and tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ea94a5a View commit details
    Browse the repository at this point in the history

  2. LGW: Add pod-route towards mpX in L2 network 

    For some reason we were not adding the reroutes
to mpX interface required in LGW in L2 topology
on the GR. This commit fixes that.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7be00b7 View commit details
    Browse the repository at this point in the history

  3. Fix name of switch for L2 

    Co-Authored-by: Patryk Diak <pdiak@redhat.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya @kyrtapz
    tssurya and kyrtapz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a350b49 View commit details
    Browse the repository at this point in the history

  4. Expose GetNodeIfAddrAnnotation as a public function 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    21db02a View commit details
    Browse the repository at this point in the history

  5. Rename generateMatch to generateNodeIPMatch 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e535317 View commit details
    Browse the repository at this point in the history

  6. Rename Add to AddSameNodeIPPolicy 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9b3eacb View commit details
    Browse the repository at this point in the history

  7. LGW: L2: Add a new LRP at 1500 for UDN 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a3cc1bd View commit details
    Browse the repository at this point in the history

  8. rename hostIfAddr to mgmtIfAddr 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d1e41e8 View commit details
    Browse the repository at this point in the history

  9. Add LGW unit tests for secondary networks topologies 

    Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bd58b4c View commit details
    Browse the repository at this point in the history

  10. Make error logs better 

    after this PR:

 unable to get logical router GR_l2.network_ovn-worker2: object not found

before this PR:

object not found

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f61fbbf View commit details
    Browse the repository at this point in the history

  11. L2: syncNodeManagementPort should be called after gwManager 

    syncNodeManagementPort should be called after the gwManager
because we want to add the routes to the GR which is only
created when the gwManager is run

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b0dd59b View commit details
    Browse the repository at this point in the history

  12. fix retries for node events in udn 

    See https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/ovn/default_network_controller.go#L920
In UDN L3/L2 controllers we were missing
checking for mgmtPortFailed and accounting for that
as part of nodeupdates. So retry for any errors from
syncManagementPort was not happening.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    12b9838 View commit details
    Browse the repository at this point in the history