Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udn, e2e: Add external client to nodeport and loadblanacer services tests #4702

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Sep 5, 2024

What this PR does and why is it needed

Add e2e test to check connectivity from external client to primary UDN nodeport and loadbalancer services

NOTE: This PR pins metallb to a commit since we don't have a release yet, but this can be fix later on.

Tests:

  • external client to nodeport service on UDPN
  • external client to externalIP service on UDPN
  • external client to loadbalancerIP service on UDPN
  • podify client at other node with nodeport
  • podify client at other node with externalIP
  • podify client at other node with LBIP

Which issue(s) this PR fixes

Fixes #4699

Add primary UDN LB and external client services

@qinqon qinqon requested a review from a team as a code owner September 5, 2024 11:40
@qinqon qinqon requested a review from kyrtapz September 5, 2024 11:40
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch from eaa9650 to 75b26c9 Compare September 5, 2024 12:24
@qinqon qinqon changed the title udn, e2e: Add external client to nodeport tests udn, e2e: Add external client to nodeport and loadblanacer services tests Sep 5, 2024
@qinqon qinqon closed this Sep 6, 2024
@qinqon qinqon reopened this Sep 6, 2024
@tssurya
Copy link
Member

tssurya commented Sep 6, 2024

we need tests for

  1. external client to nodeport service on UDPN
  2. external client to externalIP service on UDPN
  3. external client to loadbalancerIP service on UDPN
  4. other node as client (meaning node that is different from where the backend pod lives) to nodeport/externalIP/LBIP where backend pod is not on the same node as client node

@martinkennelly maybe talk to @qinqon and see if he needs you to help with half of these...?

@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 3 times, most recently from ceaf04f to b73b9e7 Compare September 9, 2024 10:50
@qinqon qinqon closed this Sep 9, 2024
@qinqon qinqon reopened this Sep 9, 2024
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 5 times, most recently from 9938c6e to 6e3bc40 Compare September 10, 2024 10:29
@qinqon
Copy link
Contributor Author

qinqon commented Sep 10, 2024

some control-plane CI is failing

Summarizing 3 Failures:
  [FAIL] Load Balancer Service Tests with MetalLB [It] Should ensure load balancer service works with pmtud
  /home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/service.go:1694
  [FAIL] Load Balancer Service Tests with MetalLB [It] Should ensure load balancer service works when ETP=local and session affinity is set
  /home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/service.go:1921
  [FAIL] Load Balancer Service Tests with MetalLB [It] Should ensure load balancer service works when ETP=local and backend pods are also egressIP served pods
  /home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/service.go:2049

@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 3 times, most recently from 308e286 to d6f508f Compare September 10, 2024 14:07
@github-actions github-actions bot added feature/egress-ip Issues related to EgressIP feature area/unit-testing Issues related to adding/updating unit tests feature/services&endpoints All issues related to the Servces/Endpoints API feature/egress-gateway All issues related to ICNI/APBR labels Sep 10, 2024
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch from d6f508f to bcbabb8 Compare September 10, 2024 14:34
@qinqon qinqon closed this Sep 10, 2024
@qinqon qinqon reopened this Sep 10, 2024
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch from bcbabb8 to a99cbef Compare September 10, 2024 15:14
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch from a99cbef to 4d96441 Compare September 11, 2024 09:01
@qinqon
Copy link
Contributor Author

qinqon commented Sep 11, 2024

Looks like CI needs more than 30s to have load balancer IPs.

@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 3 times, most recently from 5709618 to 966940c Compare September 17, 2024 12:50
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 2 times, most recently from 97efcea to 19a85dc Compare September 20, 2024 07:14
Latest metallb repo support dualstack at dev-env let's pin to it.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch 2 times, most recently from 49dee9b to 6d5accc Compare September 30, 2024 05:48
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Add testing for:
- External clients to LB, NodePort and ExternalIPs
- Podify clients to LB and ExternalIPs

Also skipping testing not working yet with local gw mode.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the primary-udn-external-to-nodePort-e2e branch from 6d5accc to 6e138a7 Compare September 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-testing area/unit-testing Issues related to adding/updating unit tests feature/egress-gateway All issues related to ICNI/APBR feature/egress-ip Issues related to EgressIP feature feature/services&endpoints All issues related to the Servces/Endpoints API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

UDN: Add external -> services e2e
2 participants