Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDN: L3: Use nodesubnet annotations for L3; not clustersubnet from NAD #4718

Merged
merged 3 commits into from
Sep 13, 2024
Merged

UDN: L3: Use nodesubnet annotations for L3; not clustersubnet from NAD #4718

merged 3 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. UDN: L3: Use nodesubnet annotations for L3 

    We were setting the hostSubnet as the clusterSubnet
for UDN L3 which was creating wrong routes in ovn
cluster router for UDN

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    309c32f View commit details
    Browse the repository at this point in the history

  2. UDN: L3: Use clustersubnets for GR routes 

    Since hostSubnets was getting feeded as clusterSubnet
when I fixed the hostSubnet in the previous commit
we started to break GR routes Let's also fix that back up.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    97b4808 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests to be more explicit 

    UTs were silently translating /16 to /24
which was not correct. Let's make the
L3 tests pass the nodesubnet in as well
to atleast make it more transparent
which is what.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
    @tssurya
    tssurya committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    961b5df View commit details
    Browse the repository at this point in the history