Direct links to Google Drive/Dropbox configuration pages from external storage config

[RobinMcCorkell]

There always seemed to be a disconnect between setting up a Google Drive/Dropbox storage on ownCloud and setting it up on the hosting provider (setting up an app etc). This PR adds a button to those backends that open the relevant configuration page directly, making it easier to use. @carlaschroder You'll probably like this

However, there's a problem that the buttons appear at the beginning of the configuration section, before the authentication fields. There's probably some fancy CSS that would fix it, or maybe we need to create a div within the configuration cell that always remains at the end, but I don't have time to implement that. I wanted to get the changes as far as I got pushed here.

cc @PVince81 @icewind1991

[mention-bot]

By analyzing the blame information on this pull request, we identified @icewind1991, @jancborchardt, @Henni and @Xenopathic to be potential reviewers

[PVince81]

@Xenopathic great idea. It would be better if it was a link, because it's more compact and also intuitively tells you that it will redirect you to some page.

I don't like it being in the middle of the config, it's messy.
One idea would be to have an extra div above all configs which allows backends to post custom status messages. So whenever at least one GDrive storage is selected, it could add a note there.
Not sure whether it is good, but could be better.

Maybe first try making it a link, then maybe with some CSS hackery we can teleport the link to some other location

[karlitschek]

great idea! 👍

[jancborchardt]

Nice! @Xenopathic since it’s a design-related pull request, do you mind putting in a screenshot so @owncloud/designers and other designers can more easily review? Thanks!

[RobinMcCorkell]

@PVince81 A link is the wrong item to use IMHO, since the behaviour of the button changes depending if there's an app key/client ID set or not. If not, it takes the user to the place they can configure a new Dropbox/GDrive app. Otherwise, it takes them directly to that app (at least with Dropbox). This also means it won't work just being at the top, above all storages...

How it looks at the moment:

How I want it to look:

[RobinMcCorkell]

The printing of "Access granted" takes up a lot of space, so I changed it to using semantic colouring instead (with the ideal button layout, not the actual button layout, that still needs to be fixed):

[carlaschroder]

Thanks @Xenopathic, early-headsup and think of shared hosting users are always good.

[PVince81]

@Xenopathic in this case it could still be a link, but the text needs to change depending on the conditions you mentioned. It's like two links, but only one is displayed at a time.

[PVince81]

We're past feature freeze, moving this to 9.1

[PVince81]

@Xenopathic 9.1 is open now, can you continue this ? 😄

[RobinMcCorkell]

Since we really want to avoid adding yet more things to the already-bloated configuration fields section, I decided to change the link to be a 'settings' icon next to the backend name, with a meaningful tooltip. Here's a screenshot:

[PVince81]

I like that better! 👍

[jancborchardt]

Maybe it should rather be an icon-help instead of icon-settings, as we use that throughout settings for external doc links. :)

[RobinMcCorkell]

@jancborchardt I considered it, but I feel that the settings icon makes more sense, since you want to configure the service-side of the storage. It's not a documentation link.

[jancborchardt]

Ok, works for me.

[RobinMcCorkell]

@DeepDiver1975 Ready to merge

[PVince81]

Conflicts ahead 😦

[PVince81]

@Xenopathic you forgot to shout "rebased!"

[PVince81]

Tested, works 👍

Great addition!

[PVince81]

@carlaschroder you might want to add a hint for this in the docs #22214 (comment)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.