fix(parser): fix panic on multi-byte char in private identifer

relates #232
oxc-project · Apr 1, 2023 · 007b773 · 007b773
1 parent 2d7677d
commit 007b773
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 52 deletions.
diff --git a/crates/oxc_parser/src/lexer/mod.rs b/crates/oxc_parser/src/lexer/mod.rs
@@ -726,11 +726,15 @@ impl<'a> Lexer<'a> {
                 self.identifier_unicode_escape_sequence(&mut builder, true);
             }
             Some(c) => {
-                self.error(diagnostics::InvalidCharacter(c, Span::new(start, self.offset() - 1)));
+                #[allow(clippy::cast_possible_truncation)]
+                self.error(diagnostics::InvalidCharacter(
+                    c,
+                    Span::new(start, start + c.len_utf8() as u32),
+                ));
                 return Kind::Undetermined;
             }
             None => {
-                self.error(diagnostics::UnexpectedEnd(Span::new(start, self.offset() - 1)));
+                self.error(diagnostics::UnexpectedEnd(Span::new(start, start)));
                 return Kind::Undetermined;
             }
         }

diff --git a/tasks/coverage/babel.snap b/tasks/coverage/babel.snap
@@ -8245,7 +8245,7 @@ Expect to Parse: "typescript/types/const-type-parameters/input.ts"
   × Invalid Character `=`
    ╭─[esprima/invalid-syntax/migrated_0065/input.js:1:1]
  1 │ i #= 42
-   ·    ▲
+   ·    ─
    ╰────
 
   × Expected a semicolon or an implicit semicolon after a statement, but found none