chore(transform_conformance): do not print comments yet (#5788)

oxc-project · Sep 15, 2024 · 213dbc0 · 213dbc0
1 parent 033b907
commit 213dbc0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/tasks/transform_conformance/src/driver.rs b/tasks/transform_conformance/src/driver.rs
@@ -2,7 +2,10 @@ use std::{mem, ops::ControlFlow, path::Path};
 
 use oxc::{
     ast::ast::Program,
+    ast::Trivias,
+    codegen::{CodeGenerator, CodegenOptions},
     diagnostics::OxcDiagnostic,
+    mangler::Mangler,
     semantic::post_transform_checker::check_semantic_after_transform,
     span::SourceType,
     transformer::{TransformOptions, TransformerReturn},
@@ -53,6 +56,18 @@ impl CompilerInterface for Driver {
         }
         ControlFlow::Continue(())
     }
+
+    // Disable comments
+    fn codegen<'a>(
+        &self,
+        program: &Program<'a>,
+        _source_text: &'a str,
+        _trivias: &Trivias,
+        mangler: Option<Mangler>,
+        options: CodegenOptions,
+    ) -> String {
+        CodeGenerator::new().with_options(options).with_mangler(mangler).build(program).source_text
+    }
 }
 
 impl Driver {

diff --git a/tasks/transform_conformance/src/test_case.rs b/tasks/transform_conformance/src/test_case.rs
@@ -299,7 +299,14 @@ impl TestCase for ConformanceTestCase {
                 |output| {
                     // Get expected code by parsing the source text, so we can get the same code generated result.
                     let ret = Parser::new(&allocator, &output, source_type).parse();
-                    CodeGenerator::new().build(&ret.program).source_text
+                    CodeGenerator::new()
+                        // .enable_comment(
+                        // &output,
+                        // ret.trivias,
+                        // CommentOptions { preserve_annotate_comments: true },
+                        // )
+                        .build(&ret.program)
+                        .source_text
                 },
             );