fix(lexer) Fix spans for jsx children (#1030)

Closes #1026
oxc-project · Oct 22, 2023 · 76ac9cd · 76ac9cd
1 parent 46207c0
commit 76ac9cd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/crates/oxc_linter/src/snapshots/jsx_key.snap b/crates/oxc_linter/src/snapshots/jsx_key.snap
@@ -95,7 +95,7 @@ expression: jsx_key
   ⚠ eslint-plugin-react(jsx-key): Missing "key" prop for element in iterator.
    ╭─[jsx_key.tsx:1:1]
  1 │ [1, 2, 3]?.map(x => <><OxcCompilerHello /></>)
-   · ──────────────────────────────────────────
+   ·                       ────────────────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-key): Missing "key" prop for element in iterator.

diff --git a/crates/oxc_linter/src/snapshots/jsx_no_useless_fragment.snap b/crates/oxc_linter/src/snapshots/jsx_no_useless_fragment.snap
@@ -35,13 +35,13 @@ expression: jsx_no_useless_fragment
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Fragments should contain more than one child.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <p><>{meow}</></p>
-   · ──────────────
+   ·    ───────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <p><>{meow}</></p>
-   · ──────────────
+   ·    ───────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Fragments should contain more than one child.
@@ -77,31 +77,31 @@ expression: jsx_no_useless_fragment
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Fragments should contain more than one child.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <Eeee><>foo</></Eeee>
-   · ──────────────
+   ·       ────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Fragments should contain more than one child.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <div><>foo</></div>
-   · ─────────────
+   ·      ────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <div><>foo</></div>
-   · ─────────────
+   ·      ────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <div><>{"a"}{"b"}</></div>
-   · ────────────────────
+   ·      ───────────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <div><>{"a"}{"b"}</></div>
-   · ────────────────────
+   ·      ───────────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
@@ -115,7 +115,7 @@ expression: jsx_no_useless_fragment
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.
    ╭─[jsx_no_useless_fragment.tsx:1:1]
  1 │ <div><Fragment>{"a"}{"b"}</Fragment></div>
-   · ────────────────────────────────────
+   ·      ───────────────────────────────
    ╰────
 
   ⚠ eslint-plugin-react(jsx-no-useless-fragment): Passing a fragment to a HTML element is useless.

diff --git a/crates/oxc_parser/src/lexer/mod.rs b/crates/oxc_parser/src/lexer/mod.rs
@@ -164,6 +164,7 @@ impl<'a> Lexer<'a> {
     }
 
     pub fn next_jsx_child(&mut self) -> Token<'a> {
+        self.current.token.start = self.offset();
         let kind = self.read_jsx_child();
         self.finish_next(kind)
     }