chore: update

oxc-project · Aug 10, 2024 · a63ec37 · a63ec37
1 parent 7c730de
commit a63ec37
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/crates/oxc_linter/src/rules/promise/no_return_in_finally.rs b/crates/oxc_linter/src/rules/promise/no_return_in_finally.rs
@@ -35,7 +35,7 @@ declare_oxc_lint!(
     /// })
     /// ```
     NoReturnInFinally,
-    correctness,
+    nursery,
 );
 
 impl Rule for NoReturnInFinally {

diff --git a/crates/oxc_linter/src/rules/promise/prefer_await_to_then.rs b/crates/oxc_linter/src/rules/promise/prefer_await_to_then.rs
@@ -39,12 +39,7 @@ impl Rule for PreferAwaitToThen {
             return;
         };
 
-        let Some(prop_name) = is_promise(call_expr) else {
-            return;
-        };
-
-        // Await statements cannot be added to the top level scope
-        if ctx.scopes().get_flags(node.scope_id()).is_top() {
+        if is_promise(call_expr).is_none() {
             return;
         }
 
@@ -73,7 +68,9 @@ fn test() {
         "a = async () => {
 			      try { await something() } catch (error) { somethingElse() }
 			    }",
-        "something().then(async () => await somethingElse())",
+        // <https://github.com/tc39/proposal-top-level-await>
+        // Top level await is allowed now, so comment this out
+        // "something().then(async () => await somethingElse())",
         "function foo() { hey.somethingElse(x => {}) }",
         "const isThenable = (obj) => {
 			      return obj && typeof obj.then === 'function';
@@ -90,6 +87,7 @@ fn test() {
         "async function a() { hey.then(function() { }).then(function() { }) }",
         "function foo() { hey.catch(x => {}) }",
         "function foo() { hey.finally(x => {}) }",
+        "something().then(async () => await somethingElse())",
     ];
 
     Tester::new(PreferAwaitToThen::NAME, pass, fail).test_and_snapshot();

diff --git a/crates/oxc_linter/src/snapshots/prefer_await_to_then.snap b/crates/oxc_linter/src/snapshots/prefer_await_to_then.snap
@@ -60,3 +60,9 @@ source: crates/oxc_linter/src/tester.rs
  1 │ function foo() { hey.finally(x => {}) }
    ·                  ────────────────────
    ╰────
+
+  ⚠ eslint-plugin-promise(prefer-await-to-then): Prefer await to then()/catch()/finally()
+   ╭─[prefer_await_to_then.tsx:1:1]
+ 1 │ something().then(async () => await somethingElse())
+   · ───────────────────────────────────────────────────
+   ╰────