Skip to content

Commit

Permalink
ci(benchmark/transformer): enable all >= es7 plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
Dunqing authored and Boshen committed Aug 29, 2024
1 parent 0eb7602 commit c29cdb0
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 5 deletions.
6 changes: 5 additions & 1 deletion crates/oxc_transformer/src/env/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@ mod data;
mod options;
mod targets;

pub use self::{data::can_enable_plugin, options::EnvOptions, targets::Versions};
pub use self::{
data::can_enable_plugin,
options::EnvOptions,
targets::{Targets, Versions},
};
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/env/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fn default_as_true() -> bool {
#[serde(default, rename_all = "camelCase", deny_unknown_fields)]
pub struct EnvOptions {
#[serde(default)]
targets: Targets,
pub targets: Targets,

#[serde(default = "default_as_true")]
pub bugfixes: bool,
Expand Down
1 change: 1 addition & 0 deletions crates/oxc_transformer/src/env/targets/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use serde::Deserialize;

use self::version::Version;

pub use self::query::Targets;
pub mod query;
pub mod version;

Expand Down
7 changes: 7 additions & 0 deletions crates/oxc_transformer/src/env/targets/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ impl Default for Targets {
}

impl Targets {
pub fn new_with_query(query: &str) -> Self {
Targets::Query(Query::Single(query.into()))
}

/// # Errors
///
/// If `targets` is not supported, this method returns an error.
pub fn get_targets(self) -> Result<Versions, Error> {
match self {
Targets::Versions(v) => Ok(v),
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ use oxc_traverse::{traverse_mut, Traverse, TraverseCtx};

pub use crate::{
compiler_assumptions::CompilerAssumptions,
env::EnvOptions,
env::{EnvOptions, Targets},
es2015::{ArrowFunctionsOptions, ES2015Options},
options::{BabelOptions, TransformOptions},
react::{ReactJsxRuntime, ReactOptions, ReactRefreshOptions},
Expand Down
10 changes: 8 additions & 2 deletions tasks/benchmark/benches/transformer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use oxc_parser::{Parser, ParserReturn};
use oxc_semantic::SemanticBuilder;
use oxc_span::SourceType;
use oxc_tasks_common::TestFiles;
use oxc_transformer::{TransformOptions, Transformer};
use oxc_transformer::{EnvOptions, Targets, TransformOptions, Transformer};

fn bench_transformer(criterion: &mut Criterion) {
let mut group = criterion.benchmark_group("transformer");
Expand Down Expand Up @@ -41,7 +41,13 @@ fn bench_transformer(criterion: &mut Criterion) {
let trivias_copy = trivias.clone();

runner.run(|| {
let transform_options = TransformOptions::default();
let env_options = EnvOptions {
// >= ES2016
targets: Targets::new_with_query("chrome 51"),
..Default::default()
};
let transform_options =
TransformOptions::from_preset_env(&env_options).unwrap();
let ret = Transformer::new(
&allocator,
Path::new(&file.file_name),
Expand Down

0 comments on commit c29cdb0

Please sign in to comment.