Skip to content

Commit

Permalink
feat(linter/unicorn): add fixer to throw-new-error (#5275)
Browse files Browse the repository at this point in the history
got merged into the wrong branch (#5148), hence setting to merge when ready (as was already approved)
  • Loading branch information
camc314 committed Aug 27, 2024
1 parent 681bd80 commit c8e8532
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions crates/oxc_linter/src/rules/unicorn/throw_new_error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ declare_oxc_lint!(
/// ```
ThrowNewError,
style,
pending
fix
);

impl Rule for ThrowNewError {
Expand Down Expand Up @@ -85,7 +85,9 @@ impl Rule for ThrowNewError {
_ => return,
}

ctx.diagnostic(throw_new_error_diagnostic(call_expr.span));
ctx.diagnostic_with_fix(throw_new_error_diagnostic(call_expr.span), |fixer| {
fixer.insert_text_before_range(call_expr.span, "new ")
});
}
}

Expand Down Expand Up @@ -143,5 +145,10 @@ fn test() {
("throw (( getGlobalThis().Error ))()", None),
];

Tester::new(ThrowNewError::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("throw Error()", "throw new Error()"),
("throw (( getGlobalThis().Error ))()", "throw new (( getGlobalThis().Error ))()"),
];

Tester::new(ThrowNewError::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}

0 comments on commit c8e8532

Please sign in to comment.