fix(parser): parse async(...null) as call expression

relates #255
oxc-project · Apr 5, 2023 · e30b992 · e30b992
1 parent 6e35678
commit e30b992
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/crates/oxc_parser/src/js/function.rs b/crates/oxc_parser/src/js/function.rs
@@ -359,8 +359,14 @@ impl<'a> Parser<'a> {
                 {
                     IsParenthesizedArrowFunction::True
                 }
-                // Rest parameter '(...a' is certainly not a parenthesized expression
-                Kind::Dot3 => IsParenthesizedArrowFunction::True,
+                // Rest parameter
+                // '(...ident' is not a parenthesized expression
+                // '(...null' is a parenthesized expression
+                Kind::Dot3 => match self.nth_kind(offset + 1) {
+                    Kind::Ident => IsParenthesizedArrowFunction::True,
+                    kind if kind.is_literal() => IsParenthesizedArrowFunction::False,
+                    _ => IsParenthesizedArrowFunction::Maybe,
+                },
                 // '([ ...', '({ ... } can either be a parenthesized object or array expression or a destructing parameter
                 Kind::LBrack | Kind::LCurly => IsParenthesizedArrowFunction::Maybe,
                 _ if self.nth_kind(offset + 1).is_binding_identifier()

diff --git a/crates/oxc_parser/src/lib.rs b/crates/oxc_parser/src/lib.rs
@@ -276,13 +276,20 @@ mod test {
         let allocator = Allocator::default();
         let source_type = SourceType::default();
 
-        let tests = [
+        let fail = [
             "1<(V=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V=uIV=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V<II>",
         ];
 
-        for source in tests {
+        for source in fail {
             let ret = Parser::new(&allocator, source, source_type).parse();
             assert!(!ret.errors.is_empty());
         }
+
+        let pass = ["async(...null)"];
+
+        for source in pass {
+            let ret = Parser::new(&allocator, source, source_type).parse();
+            assert!(ret.errors.is_empty());
+        }
     }
 }
diff --git a/tasks/coverage/babel.snap b/tasks/coverage/babel.snap
@@ -3925,7 +3925,7 @@ Expect to Parse: "typescript/types/const-type-parameters/input.ts"
   × Unexpected token
    ╭─[es2015/uncategorised/286/input.js:1:1]
  1 │ (...[ 5 ]) => {}
-   ·       ─
+   ·  ───
    ╰────
 
   × Cannot assign to 'eval' in strict mode
@@ -6920,11 +6920,10 @@ Expect to Parse: "typescript/types/const-type-parameters/input.ts"
    ·     ───
    ╰────
 
-  × Expected `=>` but found `+`
+  × Unexpected token
    ╭─[esprima/es2015-arrow-function/rest-without-arrow/input.js:1:1]
  1 │ (...a) + 1
-   ·        ┬
-   ·        ╰── `=>` expected
+   ·  ───
    ╰────
 
   × Cannot assign to 'eval' in strict mode