fix(isolated-declarations): should print constructor assignments first (

#5934)
oxc-project · Sep 21, 2024 · ea32d5b · ea32d5b
1 parent 4e9e838
commit ea32d5b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/crates/oxc_isolated_declarations/src/class.rs b/crates/oxc_isolated_declarations/src/class.rs
@@ -402,7 +402,8 @@ impl<'a> IsolatedDeclarations<'a> {
                     };
 
                     if let MethodDefinitionKind::Constructor = method.kind {
-                        elements.extend(
+                        elements.splice(
+                            0..0,
                             self.transform_constructor_params_to_class_properties(
                                 function, &params,
                             ),

diff --git a/crates/oxc_isolated_declarations/tests/fixtures/class.ts b/crates/oxc_isolated_declarations/tests/fixtures/class.ts
@@ -49,3 +49,8 @@ export class Bux {
     readonly prop3: number = 1,
   ) {}
 }
+
+export class PrivateFieldsWithConstructorAssignments {
+  private second = 0;
+  constructor(public first: number) {}
+}
diff --git a/crates/oxc_isolated_declarations/tests/snapshots/class.snap b/crates/oxc_isolated_declarations/tests/snapshots/class.snap
@@ -46,3 +46,8 @@ export declare class Bux {
 	readonly prop3: number;
 	private constructor();
 }
+export declare class PrivateFieldsWithConstructorAssignments {
+	first: number;
+	private second;
+	constructor(first: number);
+}