fix(minifier): RemoveDeadCode should visit nested expression (#4268)

oxc-project · Jul 15, 2024 · f144082 · f144082
1 parent 8fad7db
commit f144082
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/crates/oxc_minifier/src/ast_passes/remove_dead_code.rs b/crates/oxc_minifier/src/ast_passes/remove_dead_code.rs
@@ -26,6 +26,7 @@ impl<'a> VisitMut<'a> for RemoveDeadCode<'a> {
     fn visit_expression(&mut self, expr: &mut Expression<'a>) {
         self.fold_conditional_expression(expr);
         self.fold_logical_expression(expr);
+        walk_mut::walk_expression(self, expr);
     }
 }
 

diff --git a/crates/oxc_minifier/tests/oxc/remove_dead_code.rs b/crates/oxc_minifier/tests/oxc/remove_dead_code.rs
@@ -62,6 +62,12 @@ fn dce_if_statement() {
         ",
         "{foo; return }",
     );
+
+    // nested expression
+    test(
+        "const a = { fn: function() { if (true) { foo; } } }",
+        "const a = { fn: function() { { foo; } } }",
+    );
 }
 
 #[test]