-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode: don't underline if there's already an error #1653
Comments
@Boshen, here are my thoughts.
|
How does ESLint, Biome and Ruff do it? |
microsoft/vscode-eslint#1461, microsoft/vscode-eslint#222, eslint has a default 200ms debounce on client side.Also user can choose lint timing |
Let's follow! Take a look at how Biome / Ruff does it since they are written in Rust. |
both biome and ruff don't have a debounce logic, so I think following the eslint would be just fine. |
1. Closed #1653 2. Now you use `oxc-client.run` to control the lint timing. [录屏 2023年12月12日 23时39分16秒.webm](https://github.com/oxc-project/oxc/assets/17974631/123326dc-6110-4f2e-9d48-ef1a3b0a4536)
since oxc is so quick, i often get to look at overlapping underlines with the default typescript extension:
it looks ugly.
obviously, i know that it's incorrect, i just haven't finished typing yet.
if it can't be detected that error underlines are overlapping with oxc blue ones, please add an option to the vscode extension to support a debounce time in ms.
Thanks!
The text was updated successfully, but these errors were encountered: