eslint-plugin-react(jsx-key) - false positive with missing key inside React.Children.toArray()

[kristho91]

This triggers an error with oxlint:

{React.Children.toArray(items.map((item) => {
  return (
    <div>
      {item}
    </div>
  );
}))}

But it does not with eslint. When using .map inside React.Children.toArray() a key should not be necessary (to my understanding)

[vHugoObject]

Can I take this?

[Dunqing]

Can I take this?

Sure

[AlfredoPrograma]

Hello folks! Is right to pass a non children array of elements to the React.Children.toArray function?

The docs explicitly exposes that:

children parameter should be the value of the children prop received by the component.

So I'm not sure if automatic calculation keys can work with non children array of elements. If anyone has some clue about it, let me know and I contribute to this issue!

[kristho91]

I have just tested this in the new oxlint 0.8.0 . There is still a minor tweak, that needs to be fixed.
It still have a false positive when an empty fragment is used:

{React.Children.toArray(items.map((item) => {
  return (
    <>
      {item}
    </>
  );
}))}

[vHugoObject]

My apologies, I didn't add an if statement to check for React.Children for fragments. Will open up another pull request.