bug(semantic): incorrect parents for ArrayAssignmentTarget

[DonIsaac]

Consider the following JS snippet:

let _a, b;
foo.forEach(item => {
	[_a, b] = item;
	doSomething(b);
});

When the AST is viewed on the playground, _a is in the (seemingly) expected node:

https://oxc-project.github.io/oxc/playground/?code=3YCAAIDGgICAgICAgIC2mcpqpbutXC+Uf72ne1SDCJK4Tn++NlLltohMrXmjZqTqJg1QwG6pQhU2rkclTIa8/2PwyR/FKLiP+NUxD23V6F5UHPN/ezQkgA%3D%3D

However, when I get a reference to _a and iterate through its parents like so:

// here, `reference` is the restructured write on _a (the only reference _a has)
for parent in self.nodes().iter_parents(reference.node_id()) {
    println!("{:#?}", parent.kind().debug_name());
}

I get this output:

"IdentifierReference(_a)"
"SimpleAssignmentTarget"
"AssignmentTarget"
"AssignmentTarget"
"AssignmentExpression"
"ExpressionStatement"
"FunctionBody"
"ArrowFunctionExpression"
"Argument"
"CallExpression"
"ExpressionStatement"
"Program"

[Dunqing]

I cannot reproduce it in your provided playground.

[Dunqing]

I get this output:

"IdentifierReference(_a)"
"SimpleAssignmentTarget"
"AssignmentTarget"
"AssignmentTarget"
"AssignmentExpression"
"ExpressionStatement"
"FunctionBody"
"ArrowFunctionExpression"
"Argument"
"CallExpression"
"ExpressionStatement"
"Program"

Which AST is unexpected?

[DonIsaac]

_a's parent shouldn't be a simple assignment target, it should be an array pattern target.

[Dunqing]

_a's parent shouldn't be a simple assignment target, it should be an array pattern target.

I get it. That's because we don't have AstKind::ArrayAssigmentTarget

[Boshen]

We can try adding these back, given the previous hand rolled versions aren't complete

oxc/tasks/ast_codegen/src/generators/ast_kind.rs

Line 22 in e3b0c40

"ArrayAssignmentTarget",