bug(linter) incorrect fixer in no_null

[camc314]

see https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10518058484/job/29218160739?pr=25

return null!

is being fixed to

return !;

which is invalid TS

[camc314]

another one:

  x Expected a semicolon or an implicit semicolon after a statement, but found none
    ,-[packages/backend/server/src/core/quota/service.ts:73:19]
 72 |         } catch {}
 73 |         return  as unknown as typeof quota & {
    :                   ^
 74 |           feature: QuotaConfig;
    `----
  help: Try insert a semicolon here
  

[DonIsaac]

I don't have capacity for this, @camc314 can you handle it?

[DonIsaac]

Re-opening this because @Dunqing's PR only handled the first mentioned problem, not the second.

[camc314]

I'll look at this - i think i will make the fixer a lot more concervative as to whether it fixes or doesn't.

[Dunqing]

Re-opening this because @Dunqing's PR only handled the first mentioned problem, not the second.

oxc/crates/oxc_linter/src/rules/unicorn/no_null.rs

Line 383 in 05d25e2

("() => { return null as any as typeof Array }", "() => { return }", None),

It's also resolved

[camc314]

still broken 😞
although maybe this is a different issue.

const newDecorations = enabled ?
	this._debugService.getModel().getBreakpoints().map(breakpoint => {
		const parsed = CellUri.parse(breakpoint.uri);
		if (!parsed || parsed.notebook.toString() !== this._notebookEditor.textModel!.uri.toString()) {
			return null;
		}

		const options: INotebookCellDecorationOptions = {
			overviewRuler: {
				color: debugIconBreakpointForeground,
				includeOutput: false,
				modelRanges: [new Range(breakpoint.lineNumber, 0, breakpoint.lineNumber, 0)],
				position: NotebookOverviewRulerLane.Left
			}
		};
		return { handle: parsed.handle, options };
	}).filter(x => !!x) as INotebookDeltaDecoration[]
	: [];

is being fixed to:

const newDecorations = enabled ?
	
	: [];

[camc314]

@mysteryven do you want to fix this?

[DonIsaac]

I'm wondering if we should make this a suggestion 🤔

[camc314]

actually i'm not sure why our fixer works this way

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/204d31c9c2a92496a59635d9f42a532e1dc46f90/rules/no-null.js#L87-L122

unicorn:

1. if its the arg of a loose equals, suggests replacing with undefined
2. suggests deleteing the null literal if it's the argument of a return stmt
3. suggests deleting it if it's not a const var decl
4. suggests replacing with undefined

[camc314]

no worries,

i think this one is fixed now by d6b84ec (#5273)