Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): jest/prefer-todo rule #1065

Merged
merged 25 commits into from
Nov 6, 2023
Merged

feat(linter): jest/prefer-todo rule #1065

merged 25 commits into from
Nov 6, 2023

Conversation

eryue0220
Copy link
Contributor

No description provided.

@eryue0220 eryue0220 changed the title feat(linter): jest/prefer todo feat(linter): jest/prefer-todo rule Oct 26, 2023
@github-actions github-actions bot added the A-linter Area - Linter label Oct 26, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #1065 will not alter performance

Comparing eryue0220:feat/jest-prefer-todo (acad748) with main (a6ef574)

Summary

✅ 22 untouched benchmarks

@eryue0220 eryue0220 marked this pull request as draft November 1, 2023 14:09
@eryue0220 eryue0220 marked this pull request as ready for review November 1, 2023 14:46
@eryue0220 eryue0220 marked this pull request as draft November 1, 2023 16:25
@mysteryven
Copy link
Member

mysteryven commented Nov 5, 2023 •
edited
Loading

I feel your frustration being blocked by the performance. I think it's my fault. I need to improve the performance of parse_jest_fn, please wait for some time, I'll try to solve it.

@Boshen
Copy link
Member

Boshen commented Nov 6, 2023

What's left for this PR to be merged?

@mysteryven
Copy link
Member

mysteryven commented Nov 6, 2023 •
edited
Loading

What's left for this PR to be merged?

The performance. I am working to refactor the common utils.

@eryue0220
Copy link
Contributor Author

I feel your frustration(挫折) being blocked by the performance. I think it's my fault(故障). I need to improve(提高) the performance of parse_jest_fn, please wait for some time, I'll try to solve it.

Thanks. Is there any experience or tech for sharing? I tried to use flamegraph to target the problems, but noting gained.

@mysteryven
Copy link
Member

Is there any experience or tech for sharing? I tried to use flamegraph to target the problems, but noting gained.

See our performance-tuning, and you can try use VSCode repo to generate result. Hope it's enough for your usage!

@Boshen
Copy link
Member

Boshen commented Nov 6, 2023

Given this is a style which is not turned on by default, shall we try and get this merged first?

@eryue0220 eryue0220 marked this pull request as ready for review November 6, 2023 03:35
mysteryven
mysteryven approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@mysteryven mysteryven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, let merge it!

@mysteryven mysteryven merged commit 85651af into oxc-project:main Nov 6, 2023
18 checks passed
@eryue0220 eryue0220 deleted the feat/jest-prefer-todo branch January 22, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

@mysteryven mysteryven mysteryven approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eryue0220 @mysteryven @Boshen