-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter) Parse eslint configuration #1146
Conversation
This is amazing, shall we start refactoring and start merging? After getting introduced to https://graphite.dev/ and https://stacking.dev/, I prefer smaller PRs so we can iterate faster. You may also play around with graphite 😁 |
From #1146 --------- Co-authored-by: Boshen <boshenc@gmail.com>
yes! let me tidy this up today
👀 i'll take a look. Would definitly be helpful at work - I always have too many PRs open 🙂 |
👋 what happens with configs related to rules that oxc doesn't yet support? |
they'll be ignored |
Any news about this? |
667e253
to
09d48e0
Compare
176e045
to
2ac53aa
Compare
👍 Nice work! I'll test this by Monday when I have some internal code to test with. |
Will be some log to see what rules are being ignored? Or what rules of the config will being applied? Thanks. |
22dbef3
to
e571fa4
Compare
CodSpeed Performance ReportMerging #1146 will not alter performanceComparing Summary
|
e571fa4
to
ffb4cf0
Compare
@camc314 I apologize for my procrastination on reviewing and merging this PR, I'm really happy with the current state, so let's . But before shipping the next release, we need to figure out what should be done with |
any roadmap on other config file format like .eslintrc.js or .eslintrc.cjs ? |
DRAFT
Adds support for parsing
eslint
configuration files.Example:
cargo run --bin=oxc_cli lint --config-path ./.eslintrc.json .
This isn't a full implementation of how eslint parses configs but should be fine for now:
Currently supported
extends
:eslint:recommended
->eslint
plugin:react/recommended
->react
plugin:@typescript-eslint/recommended
->typescript
plugin:react-hooks/recommended
->react
plugin:unicorn/recommended
->unicorn
plugin:jest/recommended
->jest
These defaults can all be overridden by configuring the rule in the
rules
section of the estlint config:e.g.
This would enable of of the rules within the
eslint
group. But would not enableeqeqeq
as it is explicitly disabledNote, we do not currently support the following:
filter
andconfig-path
plugin
andconfig-path
Edit: