Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(linter): precompute rule.name() #1759

Merged
merged 1 commit into from
Dec 21, 2023
Merged

perf(linter): precompute rule.name() #1759

merged 1 commit into from
Dec 21, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 21, 2023

enum static dispatch has become slow because there are 200 enum variants

@github-actions github-actions bot added the A-linter Area - Linter label Dec 21, 2023
@Boshen
perf(linter): precompute rule.name()
871dc64 
enum static dispatch has become slow because there are 200 enum variants
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 21, 2023

CodSpeed Performance Report

Merging #1759 will improve performances by 39.95%

Comparing perf-linter4 (871dc64) with main (fc3a1a2)

Summary

⚡ 3 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main perf-linter4 Change
⚡ linter[antd.js] 15.2 s 10.9 s +39.95%
⚡ linter[typescript.js] 27.2 s 19.5 s +39.65%
⚡ linter[react.development.js] 211.2 ms 158.1 ms +33.57%

@Boshen Boshen marked this pull request as ready for review December 21, 2023 04:05
@Boshen Boshen merged commit e741b8f into main Dec 21, 2023
16 checks passed
@Boshen Boshen deleted the perf-linter4 branch December 21, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen