Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): Add eslint-plugin-jsdoc rulegen #1965

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

leaysgur
Copy link
Collaborator

@leaysgur leaysgur commented Jan 9, 2024

Hello. 👋🏻

This PR makes just new-jsdoc-rule xxxx command works.


Initially, I planned to implement some basic rules later.
However, after struggling for half a day, I realized that it would be challenging for a beginner like me to do it now. 😓

Once I have looked for something else I can do, and/or read more into the codebase, I hope to be able to try again at some point.

@Boshen Boshen requested a review from mysteryven January 9, 2024 09:34
Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #1965 will improve performances by 6.88%

Comparing leaysgur:main (84d8a8b) with main (4706765)

Summary

⚡ 1 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main leaysgur:main Change
semantic[pdf.mjs] 120.9 ms 113.2 ms +6.88%

@mysteryven mysteryven merged commit 8a7efc2 into oxc-project:main Jan 9, 2024
17 checks passed
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Hello. 👋🏻 

This PR makes `just new-jsdoc-rule xxxx` command works.

---

Initially, I planned to implement some basic rules later.
However, after struggling for half a day, I realized that it would be
challenging for a beginner like me to do it now. 😓

Once I have looked for something else I can do, and/or read more into
the codebase, I hope to be able to try again at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants