Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): fix crashing on empty ParenthesizedExpression with comments #263

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 6, 2023

relates #232

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Benchmark Results

Linux

group                      main                                   pr
-----                      ----                                   --
parser/babylon.max.js      1.00    105.7±0.25ms    97.7 MB/sec    1.01    106.6±0.20ms    96.9 MB/sec
parser/d3.js               1.00     13.7±0.04ms    39.9 MB/sec    1.01     13.8±0.05ms    39.5 MB/sec
parser/lodash.js           1.00      3.9±0.03ms   131.6 MB/sec    1.00      3.9±0.04ms   131.9 MB/sec
parser/pdf.js              1.00      7.5±0.07ms    53.6 MB/sec    1.00      7.5±0.09ms    53.4 MB/sec
parser/typescript.js       1.00    108.6±0.85ms    88.6 MB/sec    1.01    110.0±0.19ms    87.5 MB/sec
semantic/babylon.max.js    1.00    174.2±3.96ms    59.3 MB/sec    1.01    175.2±2.33ms    58.9 MB/sec
semantic/d3.js             1.21     23.6±2.09ms    23.2 MB/sec    1.00     19.5±1.92ms    28.1 MB/sec
semantic/lodash.js         1.10      5.6±0.12ms    91.4 MB/sec    1.00      5.1±0.15ms   100.3 MB/sec
semantic/pdf.js            1.02     12.1±0.47ms    33.4 MB/sec    1.00     11.8±0.21ms    34.1 MB/sec
semantic/typescript.js     1.00    146.1±2.59ms    65.8 MB/sec    1.02    149.2±2.50ms    64.5 MB/sec

Windows

group                      main                                   pr
-----                      ----                                   --
parser/babylon.max.js      1.00    127.7±2.74ms    80.9 MB/sec    1.02    129.7±5.02ms    79.6 MB/sec
parser/d3.js               1.00     15.8±0.37ms    34.6 MB/sec    1.00     15.8±0.31ms    34.5 MB/sec
parser/lodash.js           1.00      4.3±0.20ms   118.5 MB/sec    1.00      4.4±0.18ms   118.1 MB/sec
parser/pdf.js              1.00      8.7±0.20ms    46.2 MB/sec    1.00      8.7±0.19ms    46.2 MB/sec
parser/typescript.js       1.00    128.5±2.59ms    74.9 MB/sec    1.01    129.9±4.05ms    74.0 MB/sec
semantic/babylon.max.js    1.00    261.6±8.09ms    39.5 MB/sec    1.00    262.8±9.88ms    39.3 MB/sec
semantic/d3.js             1.00     32.5±0.77ms    16.8 MB/sec    1.05     34.0±1.53ms    16.1 MB/sec
semantic/lodash.js         1.01      7.2±0.56ms    71.3 MB/sec    1.00      7.2±0.19ms    71.6 MB/sec
semantic/pdf.js            1.01     15.0±0.47ms    26.8 MB/sec    1.00     14.8±0.33ms    27.2 MB/sec
semantic/typescript.js     1.00    221.0±6.18ms    43.5 MB/sec    1.04   229.0±11.20ms    42.0 MB/sec

@Boshen Boshen merged commit dc09020 into main Apr 6, 2023
@Boshen Boshen deleted the parser-panic branch April 6, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant