Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): do not add __source for generated nodes #3614

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions crates/oxc_span/src/span.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,21 @@ impl Span {
self.start == self.end
}

/// Returns `true` if `self` is not a real span.
/// i.e. `SPAN` which is used for generated nodes which are not in source code.
///
/// # Example
/// ```
/// use oxc_span::{Span, SPAN};
///
/// assert!(SPAN.is_unspanned());
/// assert!(!Span::new(0, 5).is_unspanned());
/// assert!(!Span::new(5, 5).is_unspanned());
/// ```
pub const fn is_unspanned(&self) -> bool {
self.start == SPAN.start && self.end == SPAN.end
}

/// Create a [`Span`] covering the maximum range of two [`Span`]s.
///
/// # Example
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_transformer/src/react/jsx_source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ impl<'a> ReactJsxSource<'a> {
elem: &mut JSXOpeningElement<'a>,
ctx: &mut TraverseCtx<'a>,
) {
// Don't add `__source` if this node was generated
if elem.span.is_unspanned() {
return;
}

// Check if `__source` attribute already exists
for item in &elem.attributes {
if let JSXAttributeItem::Attribute(attribute) = item {
Expand Down