feat(semantic): check for abstract initializations and implementations #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonIsaac
added
C-enhancement
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4125 will not alter performanceComparing Summary
|
rzvxa
approved these changes
Jul 8, 2024
rzvxa
reviewed
Jul 8, 2024
|
@DonIsaac I think for the constructors we should also add |
Merged
Boshen
added a commit
that referenced
this pull request
Jul 9, 2024
## [0.18.0] - 2024-07-09 - d347aed ast: [**BREAKING**] Generate `ast_builder.rs`. (#3890) (rzvxa) ### Features - c6c16a5 minifier: Dce all conditional expressions (#4135) (Boshen) - 365d9ba oxc_codegen: Generate annotation comments before `CallExpression` and `NewExpression` (#4119) (IWANABETHATGUY) - 3a0f2aa parser: Check for illegal modifiers in modules and namespaces (#4126) (DonIsaac) - 2f53bdf semantic: Check for abstract ClassElements in non-abstract classes (#4127) (DonIsaac) - c4ee9f8 semantic: Check for abstract initializations and implementations (#4125) (Don Isaac) - 44c7fe3 span: Add various implementations of `FromIn` for `Atom`. (#4090) (rzvxa) ### Bug Fixes - cb1af04 isolated-declarations: Remove the `async` and `generator` keywords from `MethodDefinition` (#4130) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.