Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): implement return statement dce #4155

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 10, 2024

This isn't complete, I need to figure out var hoisting 🙃

Copy link

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Jul 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-minifier Area - Minifier label Jul 10, 2024
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #4155 will not alter performance

Comparing 07-10-dce (44a894a) with main (03ad1e3)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 07-10-dce branch 2 times, most recently from 2ee3289 to 96d14c8 Compare July 10, 2024 05:45
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2024 — with Graphite App
Copy link

graphite-app bot commented Jul 10, 2024

Merge activity

This isn't complete, I need to figure out `var` hoisting 🙃
@graphite-app graphite-app bot merged commit 44a894a into main Jul 10, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-10-dce branch July 10, 2024 11:07
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Boshen added a commit that referenced this pull request Jul 11, 2024
## [0.20.0] - 2024-07-11

- 5731e39 ast: [**BREAKING**] Store span details inside comment struct
(#4132) (Luca Bruno)

### Features

- 67fe75e ast, ast_codegen: Pass the `scope_id` to the `enter_scope`
event. (#4168) (rzvxa)
- 54cd04a minifier: Implement dce with var hoisting (#4160) (Boshen)
- 44a894a minifier: Implement return statement dce (#4155) (Boshen)
- 725571a napi/transformer: Add `jsx` option to force parsing with jsx
(#4133) (Boshen)

### Bug Fixes

- 48947a2 ast: Put `decorators` before everything else. (#4143) (rzvxa)
- 7a059ab cfg: Double resolution of labeled statements. (#4177) (rzvxa)
- 4a656c3 lexer: Incorrect lexing of large hex/octal/binary literals
(#4072) (DonIsaac)
- 28eeee0 parser: Fix asi error diagnostic pointing at invalid text
causing crash (#4163) (Boshen)

### Performance

- ddfa343 diagnostic: Use `Cow<'static, str>` over `String` (#4175)
(DonIsaac)
- 2203143 semantic: Store unresolved refs in a stack (#4162) (lucab)
- fca9706 semantic: Faster search for leading comments (#4140) (Boshen)

### Documentation

- bdcc298 ast: Update the note regarding the `ast_codegen` markers.
(#4149) (rzvxa)

### Refactor

- 03ad1e3 semantic: Tweak comment argument type (#4157) (lucab)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant