Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): use stringify for generators names. #4388

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jul 21, 2024

The generator name is always the same as its identifier so this PR changes all "<generator_ident>" to stringify!(<generator_ident>)

Copy link

graphite-app bot commented Jul 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa marked this pull request as ready for review July 21, 2024 13:21
Copy link

codspeed-hq bot commented Jul 21, 2024

CodSpeed Performance Report

Merging #4388 will not alter performance

Comparing 07-21-refactor_ast_codegen_use_stringify_for_generators_names (8685932) with main (452e0ee)

Summary

✅ 32 untouched benchmarks

@overlookmotel
Copy link
Collaborator

Looks good. Do you want to move this PR out of this stack, so we can get it merged? (no worries if not)

@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 6cd87da to e2ccf8e Compare July 28, 2024 18:01
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch from a5505ac to e764b06 Compare July 28, 2024 18:01
@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from e2ccf8e to 33926f6 Compare July 29, 2024 18:18
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch from e764b06 to ad1a524 Compare July 29, 2024 18:19
@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 33926f6 to 13025a4 Compare July 30, 2024 20:33
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch 2 times, most recently from 03cce4e to 0b639a8 Compare July 30, 2024 21:13
@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from b2fdf20 to c28e09d Compare July 30, 2024 21:47
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch from 0b639a8 to 1624029 Compare July 30, 2024 21:47
@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from 1ee05bb to dee3316 Compare August 1, 2024 23:53
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch from 1624029 to 054ef97 Compare August 1, 2024 23:53
Copy link

graphite-app bot commented Aug 2, 2024

Merge activity

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 2, 2024
The generator name is always the same as its identifier so this PR changes all `"<generator_ident>"` to `stringify!(<generator_ident>)`
@rzvxa rzvxa force-pushed the 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items branch from dee3316 to eae401c Compare August 2, 2024 00:08
@rzvxa rzvxa force-pushed the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch from 054ef97 to 8685932 Compare August 2, 2024 00:09
@rzvxa rzvxa changed the base branch from 07-20-feat_ast_ast_macros_apply_stable_repr_to_all_ast_items to main August 2, 2024 00:13
@graphite-app graphite-app bot merged commit 8685932 into main Aug 2, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-21-refactor_ast_codegen_use_stringify_for_generators_names branch August 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants