Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add no-unused-vars (attempt #3) #4427

Closed
wants to merge 15 commits into from
Closed

feat(linter): add no-unused-vars (attempt #3) #4427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d5ad8a5
wip: testing and is_used fix
DonIsaac Jul 22, 2024
1faf3b6
wip: unused parameters
DonIsaac Jul 22, 2024
f52a970
wip: binding patterns, IIFEs, and fn/variable declarations
DonIsaac Jul 23, 2024
daa2d76
feat: unused spreads in function parameters
DonIsaac Jul 23, 2024
311fcf4
cleanup
DonIsaac Jul 23, 2024
e13e58a
Revert "Release crates v0.22.0" (#4415)
Dunqing Jul 23, 2024
e0c04fc
chore: fix failed publish caused by cyclic dev dependencies (#4416)
IWANABETHATGUY Jul 23, 2024
f1781b0
Release crates v0.22.0 (#4417)
github-actions[bot] Jul 23, 2024
99458f4
Revert "Release crates v0.22.0" (#4418)
Dunqing Jul 23, 2024
0ea8ea2
Revert "chore: fix failed publish caused by cyclic dev dependencies "…
Dunqing Jul 23, 2024
d6d1714
chore: fix cyclic dependencies by moving mangler tests to `oxc_minifier`
Boshen Jul 23, 2024
68d1a6e
wip: testing and is_used fix
DonIsaac Jul 22, 2024
59a950c
wip: unused parameters
DonIsaac Jul 22, 2024
687fac9
feat: unused spreads in function parameters
DonIsaac Jul 23, 2024
30d56b2
test: more ts eslint fail cases
DonIsaac Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ extend-exclude = [
"**/*.snap",
"**/*/CHANGELOG.md",
"crates/oxc_linter/fixtures",
"crates/oxc_linter/src/rules/eslint/no_unused_vars/options.rs",
"crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/eslint.rs",
"crates/oxc_linter/src/rules/jsx_a11y/aria_props.rs",
"crates/oxc_linter/src/rules/jsx_a11y/img_redundant_alt.rs",
"crates/oxc_linter/src/rules/react/no_unknown_property.rs",
Expand Down
40 changes: 20 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 20 additions & 20 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,26 +73,26 @@ cargo_common_metadata = "allow" # TODO: fix this

[workspace.dependencies]
# publish = true
oxc = { version = "0.22.0", path = "crates/oxc" }
oxc_allocator = { version = "0.22.0", path = "crates/oxc_allocator" }
oxc_ast = { version = "0.22.0", path = "crates/oxc_ast" }
oxc_codegen = { version = "0.22.0", path = "crates/oxc_codegen" }
oxc_diagnostics = { version = "0.22.0", path = "crates/oxc_diagnostics" }
oxc_index = { version = "0.22.0", path = "crates/oxc_index" }
oxc_minifier = { version = "0.22.0", path = "crates/oxc_minifier" }
oxc_mangler = { version = "0.22.0", path = "crates/oxc_mangler" }
oxc_parser = { version = "0.22.0", path = "crates/oxc_parser" }
oxc_semantic = { version = "0.22.0", path = "crates/oxc_semantic" }
oxc_span = { version = "0.22.0", path = "crates/oxc_span" }
oxc_syntax = { version = "0.22.0", path = "crates/oxc_syntax" }
oxc_transformer = { version = "0.22.0", path = "crates/oxc_transformer" }
oxc_sourcemap = { version = "0.22.0", path = "crates/oxc_sourcemap" }
oxc_ast_macros = { version = "0.22.0", path = "crates/oxc_ast_macros" }
oxc_traverse = { version = "0.22.0", path = "crates/oxc_traverse" }
oxc_module_lexer = { version = "0.22.0", path = "crates/oxc_module_lexer" }
oxc_cfg = { version = "0.22.0", path = "crates/oxc_cfg" }
oxc_isolated_declarations = { version = "0.22.0", path = "crates/oxc_isolated_declarations" }
oxc_transform_napi = { version = "0.22.0", path = "napi/transform" }
oxc = { version = "0.21.0", path = "crates/oxc" }
oxc_allocator = { version = "0.21.0", path = "crates/oxc_allocator" }
oxc_ast = { version = "0.21.0", path = "crates/oxc_ast" }
oxc_codegen = { version = "0.21.0", path = "crates/oxc_codegen" }
oxc_diagnostics = { version = "0.21.0", path = "crates/oxc_diagnostics" }
oxc_index = { version = "0.21.0", path = "crates/oxc_index" }
oxc_minifier = { version = "0.21.0", path = "crates/oxc_minifier" }
oxc_mangler = { version = "0.21.0", path = "crates/oxc_mangler" }
oxc_parser = { version = "0.21.0", path = "crates/oxc_parser" }
oxc_semantic = { version = "0.21.0", path = "crates/oxc_semantic" }
oxc_span = { version = "0.21.0", path = "crates/oxc_span" }
oxc_syntax = { version = "0.21.0", path = "crates/oxc_syntax" }
oxc_transformer = { version = "0.21.0", path = "crates/oxc_transformer" }
oxc_sourcemap = { version = "0.21.0", path = "crates/oxc_sourcemap" }
oxc_ast_macros = { version = "0.21.0", path = "crates/oxc_ast_macros" }
oxc_traverse = { version = "0.21.0", path = "crates/oxc_traverse" }
oxc_module_lexer = { version = "0.21.0", path = "crates/oxc_module_lexer" }
oxc_cfg = { version = "0.21.0", path = "crates/oxc_cfg" }
oxc_isolated_declarations = { version = "0.21.0", path = "crates/oxc_isolated_declarations" }
oxc_transform_napi = { version = "0.21.0", path = "napi/transform" }

# publish = false
oxc_macros = { path = "crates/oxc_macros" }
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_allocator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_allocator"
version = "0.22.0"
version = "0.21.0"
authors.workspace = true
description.workspace = true
edition.workspace = true
Expand Down
25 changes: 0 additions & 25 deletions crates/oxc_ast/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,6 @@ All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project does not adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) until v1.0.0.

## [0.22.0] - 2024-07-23

- f68b659 ast: [**BREAKING**] Reorder fields of `ArrowFunctionExpression` (#4364) (Dunqing)

### Features

- d345b84 ast: Add `#[ast]` attribute to non-visited AST types. (#4309) (rzvxa)
- 3c0c709 linter: Add typescript-eslint/no-extraneous-class (#4357) (Jaden Rodriguez)
- 68efcd4 linter/react-perf: Handle new objects and arrays in prop assignment patterns (#4396) (DonIsaac)

### Bug Fixes

- aece1df ast: Visit `Program`s `hashbang` field first (#4368) (overlookmotel)

### Performance
- a207923 Replace some CompactStr usages with Cows (#4377) (DonIsaac)

### Refactor

- d213773 ast: Replace serde rename "lowercase" with "camelCase" (#4376) (overlookmotel)
- abfccbd ast: Reduce `#[cfg_attr]` boilerplate in AST type defs (#4375) (overlookmotel)
- 5f1c7ec ast: Rename the `visited_node` marker to `ast`. (#4289) (rzvxa)
- 59aea73 ast: Scope is created only if CatchClause has param (#4346) (Dunqing)
- 7a3e925 ast_codegen: Better visit marker parsing. (#4371) (rzvxa)

## [0.21.0] - 2024-07-18

### Features
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_ast/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_ast"
version = "0.22.0"
version = "0.21.0"
authors.workspace = true
description.workspace = true
edition.workspace = true
Expand Down
7 changes: 0 additions & 7 deletions crates/oxc_ast_macros/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project does not adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) until v1.0.0.

## [0.22.0] - 2024-07-23

### Refactor

- abfccbd ast: Reduce `#[cfg_attr]` boilerplate in AST type defs (#4375) (overlookmotel)
- 5f1c7ec ast: Rename the `visited_node` marker to `ast`. (#4289) (rzvxa)

## [0.17.0] - 2024-07-05

### Features
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_ast_macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_ast_macros"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_cfg/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_cfg"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
8 changes: 0 additions & 8 deletions crates/oxc_codegen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project does not adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) until v1.0.0.

## [0.22.0] - 2024-07-23

### Bug Fixes

- 44a10c4 codegen: Object shorthand with parens `({x: (x)})` -> `({ x })` (#4391) (Boshen)
- 3d88f20 codegen: Print shorthand for all `{ x }` variants (#4374) (Boshen)
- e624dff codegen,mangler: Do not print shorthand for `ObjectProperty` (#4350) (Boshen)

## [0.21.0] - 2024-07-18

### Features
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_codegen"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
10 changes: 0 additions & 10 deletions crates/oxc_diagnostics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@ All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project does not adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) until v1.0.0.

## [0.22.0] - 2024-07-23

### Features
- 6068e6b Add error codes to OxcDiagnostic (#4334) (DonIsaac)

### Refactor

- 7a75e0f linter: Use diagnostic codes in lint rules (#4349) (DonIsaac)
- a2eabe1 parser: Use error codes for ts diagnostics (#4335) (DonIsaac)

## [0.20.0] - 2024-07-11

### Performance
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_diagnostics/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_diagnostics"
version = "0.22.0"
version = "0.21.0"
authors.workspace = true
description.workspace = true
edition.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_index/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_index"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_isolated_declarations/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "oxc_isolated_declarations"
version = "0.22.0"
version = "0.21.0"
publish = true
authors.workspace = true
description.workspace = true
Expand Down
Loading