Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mangler): reduce unnecessary allocation #4477

Closed
wants to merge 3 commits into from
Closed

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 26, 2024

No description provided.

Copy link

graphite-app bot commented Jul 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #4477 will not alter performance

Comparing perf-mangler-d (d4039be) with main (4d10c6c)

Summary

✅ 32 untouched benchmarks

@Dunqing Dunqing closed this Jul 26, 2024
@Boshen Boshen deleted the perf-mangler-d branch July 26, 2024 09:29
@Dunqing Dunqing restored the perf-mangler-d branch July 26, 2024 10:37
@Dunqing Dunqing reopened this Jul 26, 2024
@overlookmotel
Copy link
Collaborator

@Dunqing Codspeed is not working properly (oxc-project/backlog#82). I'd suggest closing this PR and re-opening as a new PR so it correctly compares to latest main after Rust 1.80.0 upgrade. Right now it's hard to get an accurate read on benchmarks (NB Rust upgrade also affected minifier benchmarks).

@Dunqing
Copy link
Member Author

Dunqing commented Jul 27, 2024

@Dunqing Codspeed is not working properly (#4481). I'd suggest closing this PR and re-opening as a new PR so it correctly compares to latest main after Rust 1.80.0 upgrade. Right now it's hard to get an accurate read on benchmarks (NB Rust upgrade also affected minifier benchmarks).

Thanks for pointing this out!

@Dunqing Dunqing closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants