Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make test-wasm32-unknown-unknown run unconditionally. #4624

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Aug 3, 2024

It used to be unconditional before #4547, Having it to run on all PRs allows us to run oxc_ast::generated::assert_layouts tests on 32-bit platforms.

Copy link

graphite-app bot commented Aug 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

rzvxa commented Aug 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 3, 2024 — with Graphite App
@rzvxa rzvxa marked this pull request as ready for review August 3, 2024 15:24
Copy link

graphite-app bot commented Aug 3, 2024

Merge activity

It used to be unconditional before #4547, Having it to run all PRs allows us to run `oxc_ast::generated::assert_layouts` tests on 32-bit platforms.
@overlookmotel overlookmotel force-pushed the 08-03-chore_make_test-wasm32-unknown-unknown_run_unconditionally branch from d9e636d to 61e8b8c Compare August 3, 2024 15:25
@graphite-app graphite-app bot merged commit 61e8b8c into main Aug 3, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 08-03-chore_make_test-wasm32-unknown-unknown_run_unconditionally branch August 3, 2024 15:28
@overlookmotel
Copy link
Collaborator

overlookmotel commented Aug 3, 2024

Contrary to the note above "overlookmotel added the merge label 5 hours ago — with Graphite App" I actually didn't add the merge label to this PR, or request merging it through Graphite app. I haven't used Graphite App for weeks.

Clearly Graphite made a mistake here. @Dunqing just to let you know maybe it was Graphite who merged your PR when no-one requested merging other week.

Luckily in this case, I do approve of the change and would have merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants