Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): declutter the main file. #4741

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Aug 7, 2024

The goal of this PR is to make the main file easy to follow, Now the main function is within the first page

image.png

1 similar comment
Copy link

graphite-app bot commented Aug 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa marked this pull request as ready for review August 7, 2024 19:44
Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #4741 will not alter performance

Comparing 08-07-refactor_ast_codegen_declutter_the_main_file (e40e6f6) with 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ (633fc51)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from 633fc51 to b57606c Compare August 7, 2024 20:36
@overlookmotel overlookmotel force-pushed the 08-07-refactor_ast_codegen_declutter_the_main_file branch from e40e6f6 to b57606c Compare August 7, 2024 20:37
@rzvxa
Copy link
Collaborator Author

rzvxa commented Aug 7, 2024

@overlookmotel I can't say I understand what happened here. Is it merged into downstream PRs?

@overlookmotel
Copy link
Collaborator

I did not close this PR!! I think Graphite is having a funny turn.

rzvxa added a commit that referenced this pull request Aug 7, 2024
rzvxa added a commit that referenced this pull request Aug 8, 2024
rzvxa added a commit that referenced this pull request Aug 8, 2024
rzvxa added a commit that referenced this pull request Aug 8, 2024
overlookmotel pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants