Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): alter JSON schema format #4784

Merged

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Aug 9, 2024

Change the format of schema JSON by altering serde attrs.

Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review August 9, 2024 08:59
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #4784 will not alter performance

Comparing 08-09-refactor_ast_codegen_alter_json_schema_format (3131187) with main (c79ca40)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch from de08832 to d138825 Compare August 9, 2024 09:58
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from e531eed to 7045345 Compare August 9, 2024 09:58
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch from d138825 to ba02f27 Compare August 9, 2024 10:09
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from 7045345 to b7f9308 Compare August 9, 2024 10:10
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch from ba02f27 to 39177c9 Compare August 9, 2024 10:13
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from b7f9308 to d074353 Compare August 9, 2024 10:14
@overlookmotel overlookmotel changed the base branch from 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments to graphite-base/4784 August 9, 2024 10:25
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from d074353 to 7ab0783 Compare August 9, 2024 10:29
@overlookmotel overlookmotel changed the base branch from graphite-base/4784 to main August 9, 2024 10:30
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024 — with Graphite App
Copy link

graphite-app bot commented Aug 9, 2024

Merge activity

Change the format of schema JSON by altering `serde` attrs.
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from 7ab0783 to 3131187 Compare August 9, 2024 10:52
@graphite-app graphite-app bot merged commit 3131187 into main Aug 9, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_alter_json_schema_format branch August 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants