Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(allocator): introduce Address #4810

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Aug 10, 2024

Closes #4807.

Introduce Address. Address can be obtained from a Box<T> and can act as a unique identifier for an AST node in arena.

NB: It will also be unique across 2 ASTs in different allocators as long as neither allocator is dropped.

Copy link

graphite-app bot commented Aug 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Aug 10, 2024

CodSpeed Performance Report

Merging #4810 will not alter performance

Comparing 08-10-feat_allocator_introduce_address_ (8e10e25) with main (3d40528)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-10-feat_allocator_introduce_address_ branch 2 times, most recently from 1e36a70 to d676f1e Compare August 10, 2024 12:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 11, 2024
Copy link

graphite-app bot commented Aug 11, 2024

Merge activity

  • Aug 10, 11:31 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 10, 11:31 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 10, 11:36 PM EDT: Boshen merged this pull request with the Graphite merge queue.

Closes #4807.

Introduce `Address`. `Address` can be obtained from a `Box<T>` and can act as a unique identifier for an AST node in arena.

NB: It will also be unique across 2 ASTs in different allocators as long as neither allocator is dropped.
@Boshen Boshen force-pushed the 08-10-feat_allocator_introduce_address_ branch from d676f1e to 8e10e25 Compare August 11, 2024 03:31
@graphite-app graphite-app bot merged commit 8e10e25 into main Aug 11, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 08-10-feat_allocator_introduce_address_ branch August 11, 2024 03:36
@oxc-bot oxc-bot mentioned this pull request Aug 12, 2024
Boshen added a commit that referenced this pull request Aug 12, 2024
## [0.24.2] - 2024-08-12

### Features

- 8e10e25 allocator: Introduce `Address` (#4810) (overlookmotel)

### Bug Fixes

- 62f759c transformer/typescript: Generated assignment for constructor
arguments with access modifiers should be injected to the top of the
constructor (#4808) (Dunqing)

### Performance

- 504ac0b minifier: `InjectGlobalVariables` only add to
`replaced_dot_defines` once for each (#4803) (overlookmotel)
- 35f2742 minifier: Avoid repeated `Atom` creation in
`InjectGlobalVariables` (#4802) (overlookmotel)

### Documentation

- 8827659 ast: More doc comments for JSX nodes (#4830) (DonIsaac)
- 559baa5 parser: Clean up doc regarding performance; remove conformance
(Boshen)

### Refactor

- 0ea697b ast, ast_codegen: `CloneIn` implementations now initialize
semantic related cells with `Default` value. (#4819) (rzvxa)
- ecfa124 ast_codegen: Add line break to generated code (#4829)
(overlookmotel)
- 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Address API
2 participants