Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer): re-order imports #5499

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Sep 5, 2024

Style nit. Re-order imports to make it clearer what types are external/internal to crate.

@overlookmotel overlookmotel marked this pull request as ready for review September 5, 2024 15:56
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 5, 2024
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 5, 2024
Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

  • Sep 5, 12:03 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 5, 12:04 PM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Sep 5, 12:16 PM EDT: Dunqing merged this pull request with the Graphite merge queue.

Style nit. Re-order imports to make it clearer what types are external/internal to crate.
@Dunqing Dunqing force-pushed the 09-05-refactor_transformer_clarify_match_in_regexp_transform branch from 118ef28 to 6abde0a Compare September 5, 2024 16:06
@Dunqing Dunqing force-pushed the 09-05-refactor_transformer_re-order_imports branch from 9f5545d to a96866d Compare September 5, 2024 16:06
Base automatically changed from 09-05-refactor_transformer_clarify_match_in_regexp_transform to main September 5, 2024 16:14
@graphite-app graphite-app bot merged commit a96866d into main Sep 5, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 09-05-refactor_transformer_re-order_imports branch September 5, 2024 16:16
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #5499 will create unknown performance changes

Comparing 09-05-refactor_transformer_re-order_imports (a96866d) with main (dd19823)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark main 09-05-refactor_transformer_re-order_imports Change
🆕 codegen[checker.ts] N/A 20.8 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 72.7 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 379.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 22.5 µs N/A
🆕 lexer[antd.js] N/A 19.9 ms N/A
🆕 lexer[cal.com.tsx] N/A 4.9 ms N/A
🆕 lexer[checker.ts] N/A 12 ms N/A
🆕 lexer[pdf.mjs] N/A 3.2 ms N/A
🆕 linter[cal.com.tsx] N/A 860.2 ms N/A
🆕 linter[checker.ts] N/A 1.5 s N/A
🆕 minifier[antd.js] N/A 347.9 ms N/A
🆕 minifier[react.development.js] N/A 3.6 ms N/A
🆕 minifier[typescript.js] N/A 626.5 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 77.5 µs N/A
🆕 parser[antd.js] N/A 105.4 ms N/A
🆕 parser[cal.com.tsx] N/A 24.4 ms N/A
🆕 parser[checker.ts] N/A 52.5 ms N/A
🆕 parser[pdf.mjs] N/A 17.3 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 100 µs N/A
🆕 semantic[antd.js] N/A 129.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@oxc-bot oxc-bot mentioned this pull request Sep 6, 2024
Boshen added a commit that referenced this pull request Sep 6, 2024
## [0.27.0] - 2024-09-06

- bd820f9 semantic: [**BREAKING**] Remove
`SymbolTable::get_symbol_id_from_name` and
`SymbolTable::get_scope_id_from_name` (#5480) (overlookmotel)

- cba93f5 ast: [**BREAKING**] Add `ThisExpression` variants to
`JSXElementName` and `JSXMemberExpressionObject` (#5466) (overlookmotel)

- 87c5df2 ast: [**BREAKING**] Rename `Expression::without_parentheses`
(#5448) (overlookmotel)

### Features

- e8bdd12 allocator: Add `AsMut` impl for `Box` (#5515) (overlookmotel)
- 90facd3 ast: Add `ContentHash` trait; remove noop `Hash`
implementation from `Span` (#5451) (rzvxa)
- 23285f4 ast: Add `ContentEq` trait. (#5427) (rzvxa)
- 59abf27 ast, parser: Add `oxc_regular_expression` types to the parser
and AST. (#5256) (rzvxa)
- 68a1c01 ast_tools: Add dedicated `Derive` trait. (#5278) (rzvxa)
- c782916 codegen: Print `type_parameters` in `TaggedTemplateExpression`
(#5438) (Dunqing)
- 4cb63fe index: Impl rayon related to trait for IndexVec (#5421)
(IWANABETHATGUY)
- ba4b68c minifier: Remove parenthesized expression for dce (#5439)
(Boshen)
- ed8ab6d oxc: Conditional expose `oxc_cfg` in `oxc` crate (#5524)
(IWANABETHATGUY)
- 91b39c4 oxc_diagnostic: Impl DerefMut for OxcDiagnostic (#5474)
(IWANABETHATGUY)
- 10279f5 parser: Add syntax error for hyphen in `JSXMemberExpression`
`<Foo.bar-baz />` (#5440) (Boshen)
- 0f50b1e semantic: Check for initializers in ambient
`VariableDeclaration`s (#5463) (DonIsaac)
- 62f7fff semantic: Check for non-declared, non-abstract object
accessors without bodies (#5461) (DonIsaac)
- 5407143 semantic: Check for non-declared, non-abstract class accessors
without bodies (#5460) (DonIsaac)
- 052e94c semantic: Check for parameter properties in constructor
overloads (#5459) (DonIsaac)
- 32d4bbb transformer: Add `TransformOptions::enable_all` method (#5495)
(Boshen)
- c59d8b3 transformer: Support all /regex/ to `new RegExp` transforms
(#5387) (Dunqing)
- cedf7a4 xtask: Impl `as_ast_kind` method for each variant (#5491)
(IWANABETHATGUY)

### Bug Fixes

- 0df1d9d ast, codegen, linter: Panics in fixers. (#5431) (rzvxa)
- fce549e diagnostics: Ignore `Interrupted` and `BrokenPipe` errors
while printing (#5526) (Boshen)
- ea7a52f napi/transform: Fix test (Boshen)
- 9b984b3 regex: Panic on displaying surrogated `UnicodeEscape`
characters. (#5469) (rzvxa)
- 88b7ddb regular_expression: Handle unterminated character class
(#5523) (leaysgur)
- 7a797ac semantic: Incorrect reference when `MemberExpression` used in
`TSPropertySignature` (#5525) (Dunqing)
- d8b9909 semantic: `IdentifierReference` within `TSPropertySignature`
cannot reference type-only import binding (#5441) (Dunqing)
- 8f9627d transformer: RegExp transform do not transform invalid regexps
(#5494) (overlookmotel)
- 2060efc transformer: RegExp transform don't transform all RegExps
(#5486) (overlookmotel)
- cfe5497 transformer: Do not create double reference in JSX transform
(#5414) (overlookmotel)
- 0617249 transformer/nullish-coalescing-operator: Incorrect reference
flags (#5408) (Dunqing)
- 0eb32a6 traverse: Invalid variable name generated by
`generate_uid_based_on_node` (#5407) (Dunqing)- b96bea4 Add back
lifetime (#5507) (IWANABETHATGUY)

### Performance

- bfabd8f syntax: Further optimize `is_identifier_name` (#5426)
(overlookmotel)
- aeda84f syntax: Optimize `is_identifier_name` (#5425) (overlookmotel)
- ed8937e transformer: Memoize rope instance (#5518) (Dunqing)
- bfab091 transformer: Store needed options only on `RegExp` (#5484)
(overlookmotel)
- b4765af transformer: Pre-calculate if unsupported patterns in RegExp
transform (#5483) (overlookmotel)
- 182ab91 transformer: Pre-calculate unsupported flags in RegExp
transform (#5482) (overlookmotel)

### Documentation

- 64db1b4 ast: Clarify docs for `RegExpPattern` (#5497) (overlookmotel)
- 3f204a9 span: Update docs about `ContentEq` `Vec` comparison speed
(#5478) (overlookmotel)- 00511fd Use `oxc_index` instead of `index_vec`
in doc comments (#5423) (IWANABETHATGUY)

### Refactor

- 9f6e0ed ast: Simplify `ContentEq` trait definition. (#5468) (rzvxa)
- a43e951 ast: Use loop instead of recursion (#5447) (overlookmotel)
- 2224cc4 ast: Renumber `JSXMemberExpressionObject` discriminants
(#5464) (overlookmotel)
- a952c47 ast: Use loop not recursion (#5449) (overlookmotel)
- d9d7e7c ast: Remove `IdentifierName` from `TSThisParameter` (#5327)
(overlookmotel)
- ccc8a27 ast, ast_tools: Use full method path for generated derives
trait calls. (#5462) (rzvxa)
- fdb8857 linter: Use "parsed pattern" in `no_div_regex` rule. (#5417)
(rzvxa)
- e7bd49d regular_expression: Correct typo (#5429) (overlookmotel)
- e4ed41d semantic: Change the reference flag to `ReferenceFlags::Type`
if it is used within a `TSTypeQuery` (#5444) (Dunqing)
- 94a6ac6 span: Use `Hasher` from `std` (#5476) (overlookmotel)
- b47aca0 syntax: Use `generate_derive` for `CloneIn` in types outside
of `oxc_ast` crate. (#5280) (rzvxa)
- a96866d transformer: Re-order imports (#5499) (overlookmotel)
- 6abde0a transformer: Clarify match in RegExp transform (#5498)
(overlookmotel)
- 09c522a transformer: RegExp transform report pattern parsing errors
(#5496) (overlookmotel)
- dd19823 transformer: RegExp transform do not take ownership of
`Pattern` then reallocate it (#5492) (overlookmotel)
- 2514cc9 transformer/react: Move all entry points to implementation of
Traverse trait (#5473) (Dunqing)
- c984219 transformer/typescript: Move all entry points to
implementation of Traverse trait (#5422) (Dunqing)

### Styling

- 2a43fa4 linter: Introduce the writing style from PR #5491 and reduce
the if nesting (#5512) (dalaoshu)

### Testing

- 340b535 linter/no-unused-vars: Arrow functions in tagged templates
(#5510) (Don Isaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants