Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run cargo +nightly fmt to sort imports #5503

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: run cargo +nightly fmt to sort imports #5503

merged 1 commit into from
Sep 6, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 5, 2024 •
edited
Loading

They are never going to be stable are they ...

oxc/.rustfmt.toml

Lines 8 to 16 in cedf7a4

# All unstable features that we wish for
# unstable_features = true
# version = "Two"
# Provide a cleaner impl order
# reorder_impl_items = true
# Provide a cleaner import sort order
# group_imports = "StdExternalCrate"
# Group "use" statements by crate
# imports_granularity = "Crate"

@Boshen Boshen marked this pull request as draft September 5, 2024 16:38
@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools labels Sep 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5503 will not alter performance

Comparing format (1bed5ce) with main (88b7ddb)

Summary

✅ 29 untouched benchmarks

@DonIsaac
Copy link
Collaborator

DonIsaac commented Sep 5, 2024

Nightly rust is the new stable rust 👀

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 6, 2024
@Boshen Boshen marked this pull request as ready for review September 6, 2024 04:03
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 6, 2024 •
edited
Loading

Merge activity

  • Sep 6, 12:03 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 6, 12:03 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 6, 12:09 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit 1bed5ce into main Sep 6, 2024
25 checks passed
@graphite-app graphite-app bot deleted the format branch September 6, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boshen @DonIsaac