Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace Windows-style line breaks with Unix-style in conformance fixtures #5545

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Sep 6, 2024

Replace \r\n with \n. These were the only files remaining in codebase with Windows-style line breaks.

Copy link

graphite-app bot commented Sep 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

overlookmotel commented Sep 6, 2024

@overlookmotel overlookmotel marked this pull request as ready for review September 6, 2024 12:55
@overlookmotel overlookmotel changed the base branch from 09-06-test_add_trailing_line_breaks_to_conformance_fixtures to graphite-base/5545 September 6, 2024 12:55
@overlookmotel overlookmotel merged commit dc92489 into graphite-base/5545 Sep 6, 2024
27 checks passed
@overlookmotel overlookmotel deleted the 09-06-test_replace_windows-style_line_breaks_with_unix-style_in_conformance_fixtures branch September 6, 2024 12:59
@overlookmotel overlookmotel force-pushed the 09-06-test_replace_windows-style_line_breaks_with_unix-style_in_conformance_fixtures branch from 5c95278 to dc92489 Compare September 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant