Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): remove unsafe code from logger. #5574

Merged

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Sep 7, 2024

Copy link

graphite-app bot commented Sep 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

rzvxa commented Sep 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Sep 7, 2024
@rzvxa rzvxa marked this pull request as ready for review September 7, 2024 09:00
@rzvxa
Copy link
Collaborator Author

rzvxa commented Sep 7, 2024

Merge without reviews since the change is trivial. It would've been a change request if @overlookmotel had seen the original PR in time.

@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Sep 7, 2024
Copy link

graphite-app bot commented Sep 7, 2024

Merge activity

  • Sep 7, 5:01 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 7, 5:01 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 7, 5:02 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 7, 5:03 AM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Sep 7, 5:07 AM EDT: rzvxa merged this pull request with the Graphite merge queue.

@rzvxa rzvxa force-pushed the 09-07-refactor_ast_tools_remove_unsafe_code_from_logger branch from 060c32b to 7a6b64c Compare September 7, 2024 09:03
@graphite-app graphite-app bot merged commit 7a6b64c into main Sep 7, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 09-07-refactor_ast_tools_remove_unsafe_code_from_logger branch September 7, 2024 09:07
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #5574 will not alter performance

Comparing 09-07-refactor_ast_tools_remove_unsafe_code_from_logger (7a6b64c) with main (7f7ed7b)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Collaborator

Thanks Rez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants