Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try perf no plusplus #5581

Closed
wants to merge 6 commits into from
Closed

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 7, 2024

try perf the no plus plus rules, and see if there is still has regression

Copy link

graphite-app bot commented Sep 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 7, 2024
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #5581 will degrade performances by 36.81%

Comparing fix/try-perf-no-plusplus (25ba103) with main (5f27551)

Summary

❌ 2 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/try-perf-no-plusplus Change
linter[cal.com.tsx] 858 ms 1,339.5 ms -35.95%
linter[checker.ts] 1.5 s 2.4 s -36.81%

@IWANABETHATGUY
Copy link
Contributor Author

Ok as I expected, so then

@IWANABETHATGUY IWANABETHATGUY deleted the fix/try-perf-no-plusplus branch September 7, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants