refactor(linter): Use parsed patterns in unicorn/prefer-string-starts-ends-with
#5949
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @camchenry and the rest of your teammates on |
CodSpeed Performance ReportMerging #5949 will not alter performanceComparing Summary
|
camc314
changed the base branch from
linter/use-parsed-pattern-string-replace-all
to
graphite-base/5949
camc314
force-pushed
the
09-21-refactor_linter_use_parsed_patterns_in_unicorn_prefer-string-starts-ends-with_
branch
from
546de83
to
76fdf5b
Compare
camc314
force-pushed
the
graphite-base/5949
branch
from
ce39776
to
3273b64
Compare
camc314
force-pushed
the
09-21-refactor_linter_use_parsed_patterns_in_unicorn_prefer-string-starts-ends-with_
branch
from
76fdf5b
to
625686a
Compare
camc314
approved these changes
Sep 21, 2024
Merge activity
|
…s-ends-with` (#5949) - part of #5416 This change enhances the accuracy of the `prefer_string_starts_ends_with` rule by using the parsed regex patterns for analysis. It allows for more precise detection of patterns that can be replaced with `startsWith()` and `endsWith()` methods, reducing false positives and improving the overall effectiveness of the linter. ### What changed? - Replaced the simple string-based regex analysis with a more robust AST-based approach. - Removed the `is_simple_string` function as it's no longer needed.
camc314
force-pushed
the
09-21-refactor_linter_use_parsed_patterns_in_unicorn_prefer-string-starts-ends-with_
branch
from
625686a
to
05f592b
Compare
graphite-app
bot
deleted the
09-21-refactor_linter_use_parsed_patterns_in_unicorn_prefer-string-starts-ends-with_
branch
Boshen
added a commit
that referenced
this pull request
Sep 23, 2024
## [0.9.7] - 2024-09-23 ### Features - d24985e linter: Add `oxc-security/api-keys` (#5906) (DonIsaac) - f9b44c5 linter: Add unicode sets support to `no-useless-escape` rule (#5974) (camchenry) - 0f19848 linter: Implement `no-unexpected-multiline` rule (#5911) (camchenry) - 16fe383 linter: Implement `no-extend-native` rule (#5867) (Cam McHenry) ### Bug Fixes - eed9ac7 linter: Include actual span size in `no-regex-spaces` diagnostic (#5957) (camchenry) - 40c89c2 linter: Move `promise/avoid-new` to style category (#5961) (DonIsaac) ### Performance - 608d637 linter: Use `aho-corasick` instead of `regex` for string matching in `jsx-a11y/img-redundant-alt` (#5892) (camchenry) - 3148d4b linter: Check file path after checking node kind for `nextjs/no-head-element` (#5868) (Cam McHenry) ### Refactor - 0a5a4a9 linter: Use parsed patterns for `unicorn/no-hex-escape` (#5985) (camchenry) - 2cf2edd linter: Use parsed patterns in `no-empty-character-class` rule (#5980) (camchenry) - a9a8e2a linter: Use regex parser in `eslint/no-regex-spaces` (#5952) (camchenry) - 05f592b linter: Use parsed patterns in `unicorn/prefer-string-starts-ends-with` (#5949) (camchenry) - 3273b64 linter: Use parsed patterns for `unicorn/prefer-string-replace-all` rule (#5943) (camchenry) - ba7b01f linter: Add `LinterBuilder` (#5714) (DonIsaac) - db4f16a semantic: Call `with_trivias` before `build_with_jsdoc` (#5875) (Boshen) - 3d13c6d semantic: Impl `IntoIterator` for `&AstNodes` (#5873) (DonIsaac) ### Testing - b681c9a linter: Import test cases for `no-empty-character-class` (#5981) (camchenry) - 767602b linter: Add regression test for #5227 (#5975) (camchenry) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances the accuracy of the
prefer_string_starts_ends_withrule by using the parsed regex patterns for analysis. It allows for more precise detection of patterns that can be replaced withstartsWith()andendsWith()methods, reducing false positives and improving the overall effectiveness of the linter.What changed?
is_simple_stringfunction as it's no longer needed.