Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cli): force terminal_links to reduce sys calls #911

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 14, 2023

terminal_links has auto detection on by default,
it will get repeatedly called from parser rewind
with a is_atty system call.

closes #906

terminal_links has auto detection on by default,
it will get repeatedly called from parser rewind
with a `is_atty` system call.

closes #906
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 14, 2023

CodSpeed Performance Report

Merging #911 will not alter performance

Comparing miette-links (f73c8fa) with main (dd74d93)

Summary

✅ 18 untouched benchmarks

@Boshen Boshen merged commit 9d7e165 into main Sep 14, 2023
17 checks passed
@Boshen Boshen deleted the miette-links branch September 14, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf(parser): unexpected sys call is_atty from error handling
1 participant