Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return 0 exit code when warnings<max_warnings #933

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

developit
Copy link
Contributor

@developit developit commented Sep 22, 2023

oxlint --max-warnings 99999 should exit with success status code when there are warnings but no errors found. Currently any warning or error results in an exit status of 1.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023

CLA assistant check
All committers have signed the CLA.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2023

CodSpeed Performance Report

Merging #933 will not alter performance

Comparing developit:fix/exit-code-for-max-warnings (58fbe24) with main (d700cf8)

Summary

✅ 18 untouched benchmarks

@Boshen Boshen merged commit a4c0647 into oxc-project:main Sep 23, 2023
17 checks passed
@Boshen
Copy link
Member

Boshen commented Sep 23, 2023

Thank you! I'll try and draft a release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants