Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter) Add ban_types typescript eslint rule #953

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Oct 1, 2023

Part of #503 -> @typescript-eslint/ban-types

@github-actions github-actions bot added the A-linter Area - Linter label Oct 1, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 1, 2023

CodSpeed Performance Report

Merging #953 will degrade performances by 7.19%

Comparing camc314:c/ban-types (71ce392) with main (d5b70c3)

Summary

❌ 4 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main camc314:c/ban-types Change
linter[react.development.js] 103.6 ms 109.8 ms -5.67%
linter[antd.js] 6.4 s 6.9 s -7.19%
linter[typescript.js] 11.7 s 12.6 s -7.04%
linter[vue.js] 561.1 ms 603.1 ms -6.96%

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Boshen Boshen merged commit 69f2364 into oxc-project:main Oct 3, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants