Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter) eslint-unicorn catch error name #984

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Oct 11, 2023

not sure if this is the right way - eslint plugin unicorn checks idents and looks at it's parent. but it's a bit trickier to do here

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Oct 11, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2023

CodSpeed Performance Report

Merging #984 will not alter performance

Comparing camc314:c/catch-err-name (c3ec7a8) with main (ce79bc1)

Summary

✅ 22 untouched benchmarks

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is the right way - eslint plugin unicorn checks idents and looks at it's parent. but it's a bit trickier to do here

I don't see anything tricky in the code, can you point me to the code?

crates/oxc_linter/src/rules/unicorn/catch_error_name.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/unicorn/catch_error_name.rs Outdated Show resolved Hide resolved
@camc314
Copy link
Collaborator Author

camc314 commented Oct 12, 2023

not sure if this is the right way - eslint plugin unicorn checks idents and looks at it's parent. but it's a bit trickier to do here

I don't see anything tricky in the code, can you point me to the code?

actually, just tried it - not as tricky as i thought it was - probably just my unfamiliararity with the code 🙂

@Boshen Boshen enabled auto-merge (squash) October 12, 2023 07:26
@Boshen Boshen merged commit 3af35b8 into oxc-project:main Oct 12, 2023
18 checks passed
@camc314 camc314 deleted the c/catch-err-name branch October 12, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants