refactor: don't use QueryTable for instance disks table
#2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
instance-disks-table
branch
from
c6288a0
to
9627647
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 19, 2024
oxidecomputer/console@ce242e7...5561f28 * [5561f285](oxidecomputer/console@5561f285) oxidecomputer/console#2455 * [5640bf9f](oxidecomputer/console@5640bf9f) oxidecomputer/console#2454 * [e3d42459](oxidecomputer/console@e3d42459) oxidecomputer/console#2452 * [728f1eb9](oxidecomputer/console@728f1eb9) oxidecomputer/console#2451 * [a7cb26f9](oxidecomputer/console@a7cb26f9) fix type error due to bad xterm import * [7107b5b1](oxidecomputer/console@7107b5b1) remove unused xterm-addon-fit from package.json
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 19, 2024
oxidecomputer/console@ce242e7...5561f28 * [5561f285](oxidecomputer/console@5561f285) oxidecomputer/console#2455 * [5640bf9f](oxidecomputer/console@5640bf9f) oxidecomputer/console#2454 * [e3d42459](oxidecomputer/console@e3d42459) oxidecomputer/console#2452 * [728f1eb9](oxidecomputer/console@728f1eb9) oxidecomputer/console#2451 * [a7cb26f9](oxidecomputer/console@a7cb26f9) fix type error due to bad xterm import * [7107b5b1](oxidecomputer/console@7107b5b1) remove unused xterm-addon-fit from package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for #2453 to make the diff there tiny. No behavior should change here. This table will never paginate because the list is capped at 8 items, so there's no need for
QueryTable. This also has the advantage of removing the extraneous pagination UI control from the bottom of the page.