Handle different OpenOCD configuration, hex bytes #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenOCD may return hex values from mem2array or mrw, so allow those.
mem2array output:
0 0xb8 1 0xba 2 0xc 3 0x0 4 0xb8 5 0xba
This might depend on the particular adapter driver being used but
parsing either is more robust. The problem was observed with OpenOCD
0.12.0 and cmsis-dap.
Failed with:
cargo xtask humility app/.../recovery.toml -- tasks
Finished `dev` profile [optimized + debuginfo] target(s) in 0.09s
Running `target/debug/xtask humility app/.../recovery.toml -- tasks`
humility: attached via OpenOCD
humility tasks failed: failed to read image ID at 0xcaec0; board mismatch?
Caused by:
invalid digit found in string
Error: humility failed
`mrw` requires that mem_helper.tcl is sourced, whereas read_memory can be used without any config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of small fixes for things that were preventing humility working with OpenOCD (in my setup at least). I'm not certain of the internals of OpenOCD that would cause differences between what was previously tested, maybe adapters handle their own formatting?