Add makefile linter within python flavor

Fixes #1760
oxsecurity · Aug 21, 2022 · d1d3417 · d1d3417
1 parent 14a2e41
commit d1d3417
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l
 - Fix version in URL in logs produced by reporters
 - Improve documentation for TAP_REPORTER
 - Fix flavors suggestions to ignore linters not relevant for such flavor ([#1746](https://github.com/oxsecurity/megalinter/issues/1746))
+- Add Makefile linter within python flavor
 
 - Linter versions upgrades
   - [eslint-plugin-jsonc](https://ota-meshi.github.io/eslint-plugin-jsonc/) from 2.3.1 to **2.4.0** on 2022-08-16

diff --git a/flavors/python/Dockerfile b/flavors/python/Dockerfile
@@ -221,6 +221,12 @@ RUN ML_THIRD_PARTY_DIR="/third-party/kubeconform" \
     && find ${ML_THIRD_PARTY_DIR} -type f -not -name 'LICENSE*' -delete -o -type d -empty -delete
 
 
+# checkmake installation
+RUN ( [ -d /usr/local/bin ] || mkdir -p /usr/local/bin ) \
+    && wget -q "https://github.com/mrtazz/checkmake/releases/download/0.2.1/checkmake-0.2.1.linux.amd64" -O /usr/local/bin/checkmake \
+    && chmod 755 /usr/local/bin/checkmake
+
+
 # protolint installation
 COPY --from=protolint /usr/local/bin/protolint /usr/bin/
 

diff --git a/flavors/python/flavor.json b/flavors/python/flavor.json
@@ -28,6 +28,7 @@
         "KOTLIN_KTLINT",
         "KUBERNETES_KUBEVAL",
         "KUBERNETES_KUBECONFORM",
+        "MAKEFILE_CHECKMAKE",
         "MARKDOWN_MARKDOWNLINT",
         "MARKDOWN_MARKDOWN_LINK_CHECK",
         "MARKDOWN_MARKDOWN_TABLE_FORMATTER",

diff --git a/megalinter/descriptors/all_flavors.json b/megalinter/descriptors/all_flavors.json
@@ -420,6 +420,7 @@
             "KOTLIN_KTLINT",
             "KUBERNETES_KUBEVAL",
             "KUBERNETES_KUBECONFORM",
+            "MAKEFILE_CHECKMAKE",
             "MARKDOWN_MARKDOWNLINT",
             "MARKDOWN_MARKDOWN_LINK_CHECK",
             "MARKDOWN_MARKDOWN_TABLE_FORMATTER",

diff --git a/megalinter/descriptors/makefile.megalinter-descriptor.yml b/megalinter/descriptors/makefile.megalinter-descriptor.yml
@@ -4,6 +4,7 @@ descriptor_flavors:
   - all # Applicable to CI in any language project
   - ci_light
   - dotnet
+  - python
 file_names_regex:
   - "Makefile"
 test_folder: makefile