Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MegaLinter v6 has been released ! #1592

Closed
nvuillam opened this issue Jul 10, 2022 · 20 comments
Closed

MegaLinter v6 has been released ! #1592

nvuillam opened this issue Jul 10, 2022 · 20 comments
Labels
enhancement New feature or request O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@nvuillam
Copy link
Member

nvuillam commented Jul 10, 2022

After being promised for months now, MegaLinter v6 has finally been released :)

You can see all the updates in the release notes -> https://github.com/oxsecurity/megalinter/releases/tag/v6.0.0

Just run npx mega-linter-runner@latest --upgrade to use it :) (troubleshooting)

Some linters has been removed, so if you referred to them in your configuration, you'll have to remove them

  • DOCKERFILE_DOCKERFILELINT : It was not maintained anymore and hadolint much more efficient
  • RST_RSTFMT : It was highly experimental and not maintained anymore

On some big repos, some of the new linters can be slow (like REPOSITORY_GITLEAKS) or too noisy ( like REPOSITORY_SEMGREP), don't hesitate to disable them using DISABLE_LINTERS property in .mega-linter.yml: You only can decide the linters you need !

If you see any bug/issue, please let us know !

Best regards

MegaLinter maintainers & OX Security team

Wanna know why MegaLinter has joined OX Security ? Please read the following article :)

https://nicolas.vuillamy.fr/megalinter-sells-his-soul-and-joins-ox-security-2a91a0027628

Edit: Known issues:

  • Redirection of github action megalinter/megalinter to oxsecurity/megalinter

    • GitHub deprecated automated redirections for GitHub Actions, so you need to replace megalinter/megalinter by oxsecurity/megalinter, even if you don't want to migrate to v6 yet
  • PRE_COMMANDS using npm install. Fixed in v6.0.4

  • mega-linter-runner does not upgrade report folder for uploading artifacts (mega-linter-runner --upgrade does not update report folder in Github Action Workflows #1609) Fixed in v6.0.5

    • workaround: replace manually report by megalinter-reports
@nvuillam nvuillam added the question Further information is requested label Jul 10, 2022
@nvuillam nvuillam pinned this issue Jul 10, 2022
@nvuillam nvuillam added enhancement New feature or request and removed question Further information is requested labels Jul 11, 2022
@lolrenx
Copy link

lolrenx commented Jul 11, 2022

Félicitations! Et merci de perpétuer l'esprit OSS malgré le changement de giron de Megalinter 👍

@brianpaden289
Copy link

The repo path change broke all my github actions...

Congrats on V6 and the new managers!

@nvuillam
Copy link
Member Author

The repo path change broke all my github actions...

Congrats on V6 and the new managers!

What did break exactly ?
There is an automatic redirection between old repo and new repo :/
If you give more details we may find a solution ^^

@Systemmanic
Copy link

Systemmanic commented Jul 11, 2022

Yeah it broke for us also:

image

Perhaps redirection doesn't work when using workflows that are centralized, e.g. we have our workflow that uses megalinter in a "workflows" repo that is then used by our other repos. See below.

@Systemmanic
Copy link

Systemmanic commented Jul 11, 2022

Redirects don't work for actions at all, by design:

actions/runner#1695

As per docs:

https://docs.github.com/en/actions/learn-github-actions/finding-and-customizing-actions#adding-an-action-to-your-workflow

image

@nvuillam
Copy link
Member Author

@SyncDK when I migrated from nvuillam to megalinter it worked like a charm, I did not expect this one, sorry 😭

@Kurt-von-Laven
Copy link
Collaborator

Yeah, it appears that GitHub changed this behavior between the time of the two migrations. I didn't notice since we use the pre-commit hook.

@andrewvaughan
Copy link
Contributor

Running npx mega-linter-runner still pulls the container:

Pulling docker image megalinter/megalinter:v5 ... 

Doing npx mega-linter-runner --upgrade and running again doesn't seem to do anything. Is this user error or is something up?

@nvuillam
Copy link
Member Author

nvuillam commented Jul 13, 2022

@andrewvaughan I think you have a previous version in cache.

Please can you try npm uninstall mega-linter-runner -g, then npx mega-linter-runner@latest --upgrade again ?

And if it still does not work, you can try npm i mega-linter-runner@latest -g then mega-linter-runner --upgrade

@andrewvaughan
Copy link
Contributor

That worked, thanks!

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 17, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 17, 2022
@mohsin996
Copy link

mohsin996 commented Aug 19, 2022

The repo path changes broke our GitHub actions as well, but we made slight change in the workflow.
From
uses: megalinter/megalinter@v5
To
uses: oxsecurity/megalinter@v6

Followed this template

@oxsecurity oxsecurity deleted a comment from github-actions bot Aug 19, 2022
@nvuillam
Copy link
Member Author

@mohsin996 that's what mega-linter-runner --upgrade does for you :)

It also adds megalinter-reports in .gitignore file , as the report folder has changed in v6 :)

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 22, 2022
@oxsecurity oxsecurity deleted a comment from github-actions bot Sep 22, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 22, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Oct 23, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Oct 23, 2022
@llaville
Copy link
Collaborator

llaville commented Oct 30, 2022

@nvuillam Is there any reason why MARKDOWN_REMARK_LINT was disabled in v6 (see https://oxsecurity.github.io/megalinter/latest/descriptors/markdown_remark_lint/)

Using locally to test my migration from v5 to v6

----------------------------------------------------------------------------------------------------
------------------------------------ MegaLinter, by OX Security ------------------------------------
----------------------------------------------------------------------------------------------------
 - Image Creation Date: 2022-10-23T22:50:51Z
 - Image Revision: f58627d
 - Image Version: v6
----------------------------------------------------------------------------------------------------
The MegaLinter documentation can be found at:
 - https://oxsecurity.github.io/megalinter/latest
----------------------------------------------------------------------------------------------------
MegaLinter initialization

MARKDOWN_REMARK_LINT has been temporary disabled in MegaLinter, please use a previous MegaLinter version or wait for the next one !

FYI: was disabled in context of PR #1153 (see https://github.com/oxsecurity/megalinter/blame/main/megalinter/descriptors/markdown.megalinter-descriptor.yml#L49)

@onemec
Copy link

onemec commented Nov 1, 2022

@nvuillam would it be possible to reconsider adding RST_RSTFMT back? They added support for pre-commit and although their development is rather limited, they seem to be the most extensive linter and support auto-fixing. Thanks!

@nvuillam
Copy link
Member Author

nvuillam commented Nov 1, 2022

@onemec now that python packages are installed in virtualenvs, it may be possible :)

Let's see what CI job says in the pull request :) #2035

@nvuillam
Copy link
Member Author

nvuillam commented Nov 1, 2022

@onemec rstfmt is back in beta version, and soon in next release :)

gene1wood added a commit to gene1wood/foss_photo_libraries that referenced this issue Nov 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 2, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 2, 2023
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Feb 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@nvuillam nvuillam unpinned this issue Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

9 participants