Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--remove-container has no effect #1917

Closed
mwarres opened this issue Sep 30, 2022 · 3 comments · Fixed by #1928
Closed

--remove-container has no effect #1917

mwarres opened this issue Sep 30, 2022 · 3 comments · Fixed by #1928
Assignees
@Kurt-von-Laven
Labels
bug Something isn't working

Comments

@mwarres
Copy link
Contributor

mwarres commented Sep 30, 2022

--remove-container has no effect

To Reproduce:

  1. Run docker system prune.
  2. Run docker container list --all, verifying that there are no containers present.
  3. Run npx -- mega-linter-runner@v6.10.0 --remove-container --flavor documentation --release v6.10.0.
  4. Run docker container list --all.

Expected Behavior:
Expected the final output to be empty.

Actual Behavior:
Output of step 4. is:

CONTAINER ID   IMAGE                                         COMMAND                  CREATED         STATUS                          PORTS     NAMES
747b578665c6   oxsecurity/megalinter-documentation:v6.10.0   "/bin/bash /entrypoi…"   2 minutes ago   Exited (0) About a minute ago             keen_hamilton

Thank you for taking a look at this!!
@mwarres mwarres added the bug Something isn't working label Sep 30, 2022
@nvuillam
Copy link
Member

nvuillam commented Oct 2, 2022

@Kurt-von-Laven , any idea ? ( you're the local runner expert :p )

Kurt-von-Laven added a commit that referenced this issue Oct 4, 2022
@Kurt-von-Laven
Correct removeContainer casing in runner (#1917)
5d84220 
optionator has the undocumented behavior of converting the casing of
command line arguments (e.g., it converts --remove-container to
removeContainer).
@Kurt-von-Laven Kurt-von-Laven mentioned this issue Oct 4, 2022
Merged
4 tasks
@Kurt-von-Laven
Copy link
Collaborator

As it turns out our community solved this issue only last week, so I opened a pull request with the suggested fix and filed gkz/optionator#42 to spare others similar embarrassment in the future.

@Kurt-von-Laven Kurt-von-Laven self-assigned this Oct 4, 2022
@Kurt-von-Laven Kurt-von-Laven mentioned this issue Oct 4, 2022
Merged
3 tasks
nvuillam pushed a commit that referenced this issue Oct 4, 2022
@Kurt-von-Laven
Correct removeContainer casing in runner (#1917) (#1928)
6c08b24 
optionator has the undocumented behavior of converting the casing of
command line arguments (e.g., it converts --remove-container to
removeContainer).
@mwarres
Copy link
Contributor Author

mwarres commented Oct 4, 2022

Thank you so much for fixing this!!

@vorburger vorburger mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kurt-von-Laven Kurt-von-Laven

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct casing of removeContainer in mega-linter-runner oxsecurity/megalinter
3 participants
@Kurt-von-Laven @nvuillam @mwarres