Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8r incorrectly adds the parameter -c #2756

Closed
bdovaz opened this issue Jun 21, 2023 · 1 comment · Fixed by #2819
Closed

v8r incorrectly adds the parameter -c #2756

bdovaz opened this issue Jun 21, 2023 · 1 comment · Fixed by #2819
Labels
bug Something isn't working

Comments

@bdovaz
Copy link
Collaborator

bdovaz commented Jun 21, 2023

In #1982 I included in the descriptor the configuration file but only with the intention that it generates the associated documentation because if it has the config_file_name field it generates additional documentation.

But this causes it to erroneously add the -c parameter:

[v8r] command: ['v8r', '--ignore-errors', '-v', '-c', '/tmp/lint/.v8rrc.yml', 'file1.yml', 'file2.yml']

@nvuillam the only way to solve it is to create a class for this particular linter? There is no other way, is there?

EDIT:

I knew I forgot to clarify something and that is that the -c parameter in v8r has to do with something else:

image

v8r automatically discovers the configuration file without doing anything:

image

@bdovaz bdovaz added the bug Something isn't working label Jun 21, 2023
@nvuillam
Copy link
Member

nvuillam commented Jul 2, 2023

@bdovaz I think we can also add cli_config_arg_name = '' in the descriptor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants