Upgrade dotnet to v6 #1680

lextatic · 2022-07-31T18:00:30Z

Added the project files for the sample_project_fixes tests.

But I think it won't be enough. It seems the command is being executed from the root of the repository, so it has to specify the workspace path where the project/sln file is located as the first CLI parameter when executing. Is something like this possible in the descriptor?

Maybe like this? (following what I saw in switft and repository descriptors)

    cli_lint_extra_args:
      - "{{WORKSPACE}}"
      - "--verify-no-changes"
      - "--exclude"
      - "/"
      - "--include"

* Adding dotnet project files * Better .cs examples of bad code Co-authored-by: Alexandre Melotti <contato@lexmelotti.com>

…o features/dotnet-upgrade-proposed-changes # Conflicts: # megalinter/descriptors/csharp.megalinter-descriptor.yml # megalinter/descriptors/vbdotnet.megalinter-descriptor.yml

lextatic · 2022-07-31T21:55:51Z

Everything should be okay now, the tests failing indicate that they're still expecting old dotnet 5.0 dotnet-format paremeters (with --check instead of --verify-no-changes).

Isn't there anywhere else that has to upgrade from dotnet 5.0 to dotnet 6.0?

nvuillam · 2022-07-31T22:02:30Z

@lextatic my bad, DevSkim and tsqllint use dotnet too... and I've not factorized such commands yet... I forgot to update their descriptors !
Now channel 6.0 is in all of them, I just pushed a new commit

Install commands are the following, are they still ok for dotnet v6 ?

      RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
          && chmod +x dotnet-install.sh \
          && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
    - ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"

…o features/dotnet-upgrade-proposed-changes

lextatic · 2022-08-01T03:21:08Z

Install commands are the following, are they still ok for dotnet v6 ?

I wouldn't know, will have to look into it. I think we're still missing something.

Edit: I think it's alright -- https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script

This reverts commit 995e9df.

…roposed-changes

megalinter/descriptors/csharp.megalinter-descriptor.yml

lextatic · 2022-12-03T13:15:10Z

@nvuillam Forgot to tag you in the previous comment, but I went on and decided to remove the list_of_files parameter for now and keep the dotnet6 since I wasn't able to make devskim and tsq-lint work with dotnet7. Please check the changes on DotnetFormatLinter.py to see if everything is okay there.

And there is still an issue with Terraform/Terrascan??? Can you check into that as well?

I had to sort the csharp and vbdotnet tests into separated good and bad folders in order to make it run properly, without the --include working I had to keep those files as distinct projects. I know it's not ideal, but we can revert this and put the --include paramenter back once I get an answer or fix from that issue I posted on the dotnet-format repo, but since the parameter is still not working even in the latest version of dotnet I thought it would be a better idea do leave it out.

…pgrade-proposed-changes

nvuillam · 2022-12-22T22:30:47Z

@lextatic sorru for the delay... go for dotnet v7 if it has retrocompability with v6 :) ( I wouldn't like dotnet6 users to not be able to use ML )

…pgrade-proposed-changes # Conflicts: # CHANGELOG.md # Dockerfile # flavors/dotnet/Dockerfile # megalinter/descriptors/csharp.megalinter-descriptor.yml

codecov-commenter · 2023-01-05T21:46:44Z

Codecov Report

Merging #1680 (7f206ca) into main (1688acf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   82.97%   82.99%   +0.02%     
==========================================
  Files         170      170              
  Lines        4469     4470       +1     
==========================================
+ Hits         3708     3710       +2     
+ Misses        761      760       -1

Impacted Files	Coverage Δ
megalinter/Linter.py	`84.69% <100.00%> (+0.02%)`	⬆️
megalinter/linters/DotnetFormatLinter.py	`100.00% <100.00%> (ø)`
megalinter/utils.py	`82.96% <100.00%> (ø)`
megalinter/reporters/UpdatedSourcesReporter.py	`89.74% <0.00%> (+2.56%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bdovaz · 2023-01-05T23:10:56Z

@lextatic note that the csharpier installation is set to 0.16.0 because in the main branch we are on .NET 5 but when you upgrade to .NET 7 you will probably have to remove "--version 0.16.0" to install the latest version.

lextatic · 2023-01-05T23:27:58Z

@lextatic note that the csharpier installation is set to 0.16.0 because in the main branch we are on .NET 5 but when you upgrade to .NET 7 you will probably have to remove "--version 0.16.0" to install the latest version.

Thanks, I'm removing the version arguments from the CLI but I think more stuff had failed because of the upgrade. Feel free to contribute with this PR if you know how to handle it.

If we can't do it we can revert it back to .NET 6 as it was working fine and passing all tests there. Keeping it as .NET 6 isn't that bad since .NET 6 is the LTS and .NET 7 is just a STS, meaning both will be supported until the release of .NET 8.

nvuillam · 2023-01-05T23:46:06Z

Agreed that LTS is much netter than STS, i thought dotnet v7 was also also lts bit if it's not the case it's probably better to remain on dotnet v6

bdovaz · 2023-01-05T23:49:34Z

Agreed that LTS is much netter than STS, i thought dotnet v7 was also also lts bit if it's not the case it's probably better to remain on dotnet v6

@nvuillam I don't know if it is relevant to the use we make of it but just to keep it in mind:

https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/

echoix · 2023-01-05T23:50:05Z

It depends. If all the tools we need can run 7, we can use 7, dotnet always increases performance (it is always checked when integrating new changes, if it slows downs it isn't really accepted).

I don't think that the dotnet tools need to run the user's repo dotnet code, so we use the version we want.

echoix · 2023-01-05T23:51:22Z

@bdovaz same thoughts

nvuillam · 2023-01-05T23:53:28Z

If v7 is STS, i don't know about the user adoption

And as i do not use dotnet, i have no idea 😅

All I know for sure is that we need to stop being with dotnet v5 ^^

bdovaz · 2023-01-05T23:56:58Z

If v7 is STS, i don't know about the user adoption

And as i do not use dotnet, i have no idea 😅

All I know for sure is that we need to stop being with dotnet v5 ^^

The only difference is the support time: https://dotnet.microsoft.com/en-us/platform/support/policy

In terms of stability and quality they assure that they have the same standards, it's not that .NET 7 is "beta" or something similar.

echoix · 2023-01-05T23:58:41Z

And we know a new one will exist after that.

nvuillam · 2023-01-05T23:59:41Z

So like @echoix said, if all the apps we use are compliant, we could go with v7 and switch to v8 that will be released long before the end of v7 support, indeed :)

This reverts commit 7630633.

lextatic · 2023-01-06T03:05:06Z

I've made some tests and it seems like Devskim is blocking us again, also some other tests are failing that would need more time to investigate why.

So how about that?

Since it's already working fine with v6 we proceed with it for this PR and further investigate if we can upgrade to v7 on a future PR. At least this way we're out of v5 and on to a LTS version of .NET.

nvuillam

Great job , many many thanks for this huge contribution :)

megalinter/descriptors/repository.megalinter-descriptor.yml

nvuillam · 2023-01-06T06:54:56Z

@lextatic i think DevSkim is simply not compliant with v7... it's compliant with v6 for a few time, and after my request ^^

microsoft/DevSkim#391

bdovaz · 2023-01-06T10:36:00Z

@lextatic @nvuillam the alpha versions are compatible with .NET 7, you can test them in a PR in draft if you want and wait until that version is stable:

https://www.nuget.org/packages/Microsoft.CST.DevSkim.CLI/0.8.8-alpha#supportedframeworks-body-tab

nvuillam · 2023-01-06T10:46:48Z

I think we'll wait all official releases are compliant with v7, else we'll wait for v8 :)
That's already a big step to be with dotnet v6 :)

nvuillam and others added 12 commits July 24, 2022 21:33

Upgrade dotnet to v6 + list_of_files for dotnet-format

e2f8c5b

Fixes

cf820a9

Fixes

e794e49

Merge branch 'main' into features/dotnet-upgrade

92e3137

Adding dotnet project files

c140688

Better .cs examples of bad code

35fca2b

Dotnet Upgrade project files (#1679)

be35811

* Adding dotnet project files * Better .cs examples of bad code Co-authored-by: Alexandre Melotti <contato@lexmelotti.com>

Merge branch 'main' into features/dotnet-upgrade

072621f

Update doc

14c527d

Adding .csproj files to sample_project_fixes

bfc1ba7

Added .sln info on linter_text property

14d70b6

Merge remote-tracking branch 'oxsecirity/features/dotnet-upgrade' int…

ba6e914

…o features/dotnet-upgrade-proposed-changes # Conflicts: # megalinter/descriptors/csharp.megalinter-descriptor.yml # megalinter/descriptors/vbdotnet.megalinter-descriptor.yml

lextatic requested a review from nvuillam as a code owner July 31, 2022 18:00

Alexandre Melotti added 2 commits July 31, 2022 15:07

Updated linter URL and added {{WORKSPACE}} CLI arg

4433588

Unifying vb and csharp projects into one single solution

bec39b4

Alexandre Melotti and others added 2 commits July 31, 2022 19:01

Upgrade dotnet version on linter dockers

995e9df

Really upgrade dotnet everywhere

08e80ba

Merge remote-tracking branch 'oxsecirity/features/dotnet-upgrade' int…

f8b92cc

…o features/dotnet-upgrade-proposed-changes

nvuillam and others added 5 commits August 1, 2022 07:20

Merge branch 'main' into features/dotnet-upgrade

ff77273

Revert "Upgrade dotnet version on linter dockers"

c96e1e9

This reverts commit 995e9df.

Merge branch 'features/dotnet-upgrade' into features/dotnet-upgrade-p…

dae34ab

…roposed-changes

Testing some Dockerfile configs

f751c73

dotnet info

d84ae29

nvuillam reviewed Aug 4, 2022

View reviewed changes

megalinter/descriptors/csharp.megalinter-descriptor.yml Outdated Show resolved Hide resolved

Alexandre Melotti added 3 commits August 4, 2022 23:02

Trying to figure out dotnet version running on each test case

33c246b

Checking root's workspace

f6d5342

Checking for tool versions

0bdb723

Removing unused import from DotnetFormatLinter.py

e54901b

Merge remote-tracking branch 'oxsecirity/main' into features/dotnet-u…

dc5d945

…pgrade-proposed-changes

This was referenced Dec 22, 2022

Override npm-package-json-lint flavors #2173

Merged

Add CSharpier linter #2185

Merged

bdovaz mentioned this pull request Jan 5, 2023

ARM64 docker images #1553

Merged

Merge remote-tracking branch 'oxsecirity/main' into features/dotnet-u…

4e5b040

…pgrade-proposed-changes # Conflicts: # CHANGELOG.md # Dockerfile # flavors/dotnet/Dockerfile # megalinter/descriptors/csharp.megalinter-descriptor.yml

Upgrade to dotnet 7

7630633

Removing csharpier version specification from install cli

7a8d094

lextatic added 2 commits January 5, 2023 22:44

Revert "Upgrade to dotnet 7"

bde05c3

This reverts commit 7630633.

Updating changelog, removed 'list_of_files' for now

7f206ca

nvuillam approved these changes Jan 6, 2023

View reviewed changes

megalinter/descriptors/repository.megalinter-descriptor.yml Outdated Show resolved Hide resolved

nvuillam merged commit b549994 into oxsecurity:main Jan 6, 2023

echoix mentioned this pull request Feb 5, 2023

DotNet format linter does not work properly for projects using .NET versions other than .NET 6 #2310

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade dotnet to v6 #1680

Upgrade dotnet to v6 #1680

lextatic commented Jul 31, 2022

lextatic commented Jul 31, 2022

nvuillam commented Jul 31, 2022 •

edited

Loading

lextatic commented Aug 1, 2022 •

edited

Loading

lextatic commented Dec 3, 2022

nvuillam commented Dec 22, 2022

codecov-commenter commented Jan 5, 2023 •

edited

Loading

bdovaz commented Jan 5, 2023

lextatic commented Jan 5, 2023

nvuillam commented Jan 5, 2023 •

edited

Loading

bdovaz commented Jan 5, 2023

echoix commented Jan 5, 2023

echoix commented Jan 5, 2023

nvuillam commented Jan 5, 2023

bdovaz commented Jan 5, 2023

echoix commented Jan 5, 2023

nvuillam commented Jan 5, 2023 •

edited

Loading

lextatic commented Jan 6, 2023

nvuillam left a comment

nvuillam commented Jan 6, 2023

bdovaz commented Jan 6, 2023

nvuillam commented Jan 6, 2023

Upgrade dotnet to v6 #1680

Upgrade dotnet to v6 #1680

Conversation

lextatic commented Jul 31, 2022

lextatic commented Jul 31, 2022

nvuillam commented Jul 31, 2022 • edited Loading

lextatic commented Aug 1, 2022 • edited Loading

lextatic commented Dec 3, 2022

nvuillam commented Dec 22, 2022

codecov-commenter commented Jan 5, 2023 • edited Loading

Codecov Report

bdovaz commented Jan 5, 2023

lextatic commented Jan 5, 2023

nvuillam commented Jan 5, 2023 • edited Loading

bdovaz commented Jan 5, 2023

echoix commented Jan 5, 2023

echoix commented Jan 5, 2023

nvuillam commented Jan 5, 2023

bdovaz commented Jan 5, 2023

echoix commented Jan 5, 2023

nvuillam commented Jan 5, 2023 • edited Loading

lextatic commented Jan 6, 2023

nvuillam left a comment

Choose a reason for hiding this comment

nvuillam commented Jan 6, 2023

bdovaz commented Jan 6, 2023

nvuillam commented Jan 6, 2023

nvuillam commented Jul 31, 2022 •

edited

Loading

lextatic commented Aug 1, 2022 •

edited

Loading

codecov-commenter commented Jan 5, 2023 •

edited

Loading

nvuillam commented Jan 5, 2023 •

edited

Loading

nvuillam commented Jan 5, 2023 •

edited

Loading