Deploy additional Docker images to GitHub Container Registry

[lars-reimann]

Fixes partially #1472

Proposed Changes

1. Deploy additional Docker images to GitHub Container Registry. This would later allow action.yml to pull the MegaLinter image from GitHub instead of Docker Hub, which should speed up the pull phase of the action.

Readiness Checklist

Author/Contributor

• Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[lars-reimann]

Some questions about this:

1. Should other deploy workflows also be updated? This includes
   • deploy-ALPHA-flavors.yml
   • deploy-BETA-flavors.yml
   • deploy-BETA-linters.yml
   • deploy-DEV.yml
   • deploy-DEV-linters.yml
   • deploy-RELEASE-linters.yml
2. Should this PR also update action.yml or should this be done in a separate PR?
3. How can I test these changes?

Once these questions are answered, I'll update the CHANGELOG accordingly.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

[bdovaz]

Ping @nvuillam, can you answer this questions?

[nvuillam]

@bdovaz beta, beta-flavors and beta-linters will validate that it work, so the release jobs have more chances to work too :)

[lars-reimann]

I recently found this discussion claiming that GHCR is no faster than Docker Hub for GitHub Actions. So, I wonder whether it makes sense to further pursue this PR.

[nvuillam]

docker pulls on docker hub has download limitations (not applied on github actions), so it still can be iteresting to use ghcr image, especially for self hossted runners :)

[Kurt-von-Laven]

Thai Pangsakulyanont reported improved performance building and pushing to GHCR, which makes me skeptical that pulling is somehow slower. We wrote ScribeMD/docker-cache, automating approach 📦 in the blog post, and it outperforms pulling directly from Docker Hub. In any case, we should measure the performance ourselves since it may have changed over time.

[echoix]

And what about simply when there are some outages? It is native to GitHub, and the whole build doesn't need to be done twice anyway, only two pushes instead of one.

[lars-reimann]

I can continue with this next week. If someone else wants to work on it in the meantime, feel free to do so.

[codecov-commenter]

Codecov Report

Merging #2117 (7ccbd12) into main (841b135) will increase coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
+ Coverage   82.60%   83.11%   +0.51%     
==========================================
  Files         170      170              
  Lines        4484     4484              
==========================================
+ Hits         3704     3727      +23     
+ Misses        780      757      -23     

Impacted Files	Coverage Δ
megalinter/config.py	92.30% <0.00%> (ø)
megalinter/tests/test_megalinter/config_test.py	100.00% <0.00%> (ø)
megalinter/reporters/UpdatedSourcesReporter.py	89.74% <0.00%> (+2.56%)	⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py	89.01% <0.00%> (+8.05%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bdovaz]

@lars-reimann you need to add this word to .cspell.json file:

[nvuillam]

Great PR, nice job, thanks a lot for your contribution :)

[nvuillam]

When i try to merge i have an error :/

[echoix]

When i try to merge i have an error :/

Did you try on web instead of app? I can't imagine why an OAuth app is involved in that. Of course I never saw the settings on admin side, but changes to workflows have been done even during the holidays without problems.

[Kurt-von-Laven]

By default, bots can't edit .github/workflows for security reasons (c.f., orgs/community#25222, orgs/community#26164). In this case, since the error is coming from an OAuth App, it's possible to grant it the workflow scope if desired. I don't know which OAuth App this is though, so I can't comment on whether granting it the ability to execute arbitrary code in our name would be wise.

[nvuillam]

@Kurt-von-Laven @echoix it worked thru web UI :)

[nvuillam]

thanks again @lars-reimann :)